1093712 - Loadee does not call frames if Loader is not on the stage

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Yury Delendik (:yury)]

If loadee is not added to the main stage, the frames code is not called, e.g.

 _loader = new Loader();
 _loader.contentLoaderInfo.addEventListener(Event.COMPLETE, loader_complete);
 // notice no addChild(_loader);
 _loader.load(new URLRequest("Loadee.swf"));

When loader_complete is called, Loadee.swf does not call any frame scripts however Loadee's frame(s) was advanced.

Breaks any video players built based on standard video component.

Comment 1

[Chris Peterson [:cpeterson]]

Yury says this affects video players using Adobe's video component.

Comment 2

[Tobias Schneider [:tobytailor]]

Attachment: Link to Github pull-request: https://github.com/mozilla/shumway/pull/2058

The issue here is that in the event loop we call _enqueueFrameScripts only on instances of MovieClip which excludes Loaders. We should call it on all items in DisplayObject._advancableInstances. Moved the instanceof check into an relase || assert since advancableInstances should already only contain objects of type DisplayObjectContainer.

Comment 3

[Tobias Schneider [:tobytailor]]

So sorry for totally being wrong with my previous assumption. Of course we always have to do the instanceof check, but doing so to check for DisplayObjectContainers, not just MovieClips. Updated the pull-request, still asking for review :).

Comment 4

[Till Schneidereit [:till]]

Comment on attachment 8560183 [details] [review]
Link to Github pull-request: https://github.com/mozilla/shumway/pull/2058

Looks good, thanks.

Comment 5

[Tobias Schneider [:tobytailor]]

Fixed in https://github.com/mozilla/shumway/pull/2058.