Closed Bug 1093766 Opened 10 years ago Closed 10 years ago

DevEdition branding: About dialog has a black strip on the right side

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 36
Tracking Flags:
Tracking Status
firefox35 --- fixed
firefox36 --- verified

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(3 files)

about-dialog.png
317.87 KB, image/png
Details
about-dialog-color.patch
943 bytes, patch
jaws
: review+
Details | Diff | Splinter Review
with-patch.png
259.19 KB, image/png
Details
Attached image about-dialog.png — 
See screenshot.  And also Bug 890973.
Summary: DevEdition Theme: About dialog has a black strip on the right side → DevEdition branding: About dialog has a black strip on the right side
This isn't perfect, but it looks a lot less jarring.  What do you think?  Screenshot incoming
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8516879 - Flags: review?(jaws)
Attached image with-patch.png — 

    
  
Blocks: 1072181
No longer blocks: 1053434

    
  
Blocks: fx-dev-edition

    
    

    
  
Comment on attachment 8516879 [details] [diff] [review]
about-dialog-color.patch

Review of attachment 8516879 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

        Attachment #8516879 -
        Flags: review?(jaws) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/6ddcc5266799
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36

    
    

    
  
Verified in the latest GUM build (BuildID=20141105175749) on Windows 7 x64, Mac OS X 10.9.5, Ubuntu 14.04 x64, and About displays same as indicated in attachment from comment 2. Since this is the accepted fix, this can be considered Verified.

          status-firefox36:
          --- → verified
Group: mozilla-employee-confidential

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: