890973 - About dialog background image has odd black stripe on the far end

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Screenshot of bug

When the Nightly images were changed in bug 840883, the background color of the About dialog wasn't updated to match the color that the image fades to. This is causing a black stripe on the far end of the dialog. See attached screenshot.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Also fixed up the background color for Aurora.

Comment 2

[Scoobidiver (away)]

What about the bottom black strip for Nightly (not UX)?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(In reply to Scoobidiver from comment #2)
> What about the bottom black strip for Nightly (not UX)?

Luckily, the patch that jaws has put together will work for both Nightly and UX Nightly. :)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 772128 [details] [diff] [review]
Patch

Review of attachment 772128 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Good catch, Jared.

Comment 5

[Théo Chevalier]

Attachment: Screenshot of bottom bug (French build, Ubuntu)

Mike, I think Scoobidiver was talking about the image being too short at the bottom on some build/locales, as you can notice here. (17px missing)

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Scoobidiver from comment #2)
> What about the bottom black strip for Nightly (not UX)?

(In reply to Théo Chevalier [:tchevalier] from comment #5)
> Created attachment 772282 [details]
> Screenshot of bottom bug (French build, Ubuntu)
> 
> Mike, I think Scoobidiver was talking about the image being too short at the
> bottom on some build/locales, as you can notice here. (17px missing)

That is tracked by bug 811080.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f22655c8a5c

Comment 8

[Scoobidiver (away)]

(In reply to Théo Chevalier [:tchevalier] from comment #5)
> Mike, I think Scoobidiver was talking about the image being too short at the
> bottom on some build/locales, as you can notice here. (17px missing)
It's applicable to en-US Nightly.

(In reply to Jared Wein [:jaws] from comment #6)
> That is tracked by bug 811080.
No. It's not about links but the background image.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9f22655c8a5c