1094058 - [flatfish] build break by gecko/widget/gonk/HwcComposer2D.h:132

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Danny Liang [:dliang]]

Attachment: build.log.2

This a build break by gecko/widget/gonk/HwcComposer2D.h:132

In file included from ../../../gecko/gfx/gl/GLContextEGL.h:14:0,
                 from ../../../gecko/gfx/gl/EGLUtils.cpp:7,
                 from Unified_cpp_gfx_gl0.cpp:29:
../../../gecko/widget/gonk/HwcComposer2D.h:132:5: error: 'nsecs_t' does not name a type
In file included from ../../../gecko/gfx/gl/GLBlitHelper.cpp:16:0,
                 from Unified_cpp_gfx_gl0.cpp:38:
../../dist/include/GrallocImages.h: In static member function 'static int mozilla::layers::GrallocImage::GetOmxFormat(int)':
../../dist/include/GrallocImages.h:115:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
In file included from Unified_cpp_gfx_gl0.cpp:74:0:
../../../gecko/gfx/gl/GLContextProviderEGL.cpp: In function 'bool mozilla::gl::CreateConfig(void**, int32_t)':
../../../gecko/gfx/gl/GLContextProviderEGL.cpp:663:41: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
...
make[6]: *** [Unified_cpp_gfx_gl0.o] Error 1
make[5]: *** [gfx/gl/target] Error 2
make[5]: *** Waiting for unfinished jobs....

Comment 1

[Danny Liang [:dliang]]

This build break is caused by bug 1083530, you can revert below two commits to avoid the build break.

commit fb2714672fb6aa0d7c5133be6f9a6005433b181c
Author: Mason Chang <[e-mail]>
Date:   Wed Oct 29 13:37:06 2014 -0700

    bug 1083530. Part 2 Refactor GeckoTouchDispacher to use mozilla::Timestamp instead of nsecs_t. r=mwu

commit 97ebd4c29a7db8f5a873498a01f25d06787f5f64
Author: Mason Chang <[e-mail]>
Date:   Wed Oct 29 13:36:51 2014 -0700

    Bug 1083530. Part 1 Create mozilla::TimeStamp constructor with system time param. r=roc

Comment 2

[Danny Liang [:dliang]]

Hi Mason, Would you mind checking this build break on flatfish?

Comment 3

[Danny Liang [:dliang]]

Update SW version:
Gecko: c0265bde5c70b4f1b8cd4cf8a614733e58ff6123
Gaia: 6f96a078fef1e8ca2f71b07916eef4eb2ba64943

Comment 4

[Mason Chang [Inactive] [:mchang]]

Hi Danny, do you have a backup-flatfish anywhere? I don't have a device so I can't build locally. Any idea why this only occurs on flatfish and this isn't tested on try servers or b2g-inbound? I expect that bug 1094059 should be fixed after we fix this one as well.

Comment 5

[Mason Chang [Inactive] [:mchang]]

Attachment: Temporary Fix, typedef nsecs_t

Temporary fix to define nsecs_t, but I'm still very confused why this only breaks on flatfish. What version of android is flatfish on?

Comment 6

[Yousef Alam [:yalam96] (use NEEDINFO)]

Version is 4.2.2

Comment 7

[Safwan Rahman (:safwan)]

It should be blocker bug as its breaking the build of flatfish

Comment 8

[Mason Chang [Inactive] [:mchang]]

Do we have backup flatfish blobs anywhere? The one on the intranet is broken with this error:

Pulling "audio.a2dp.default.so"
Pulling "bluetooth.default.so"
cp: cannot stat ‘../../../backup-flatfish/system/lib/hw/bluetooth.default.so’: No such file or directory
Failed to pull bluetooth.default.so. Giving up.

############################################################
Can't find necessary file(s) of Bluedroid in the backup-flatfish folder.
Please update the system image for supporting Bluedroid (Bug-986314), 
so that the needed binary files can be extracted from your flatfish device.
############################################################

Comment 9

[Safwan Rahman (:safwan)]

Mason, thanks for your comment. Can you please let us know what do you need?

Comment 10

[Yousef Alam [:yalam96] (use NEEDINFO)]

Sent my copy via email.

Comment 11

[Mason Chang [Inactive] [:mchang]]

Attachment: Include <utils/Timer.h> for nsecs_t definition

Comment 12

[Mason Chang [Inactive] [:mchang]]

Asked sheriff approval as required by b2g-inbound right now and was told to use checkin-needed. Tested locally and seems to fix this specific error, but I still can't complete a build due to bug 1087096.

Comment 13

[Mason Chang [Inactive] [:mchang]]

Try build only: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=bdd6fedc2361

Comment 14

[Danny Liang [:dliang]]

By my test, with the patch and do revert command of comment 10, flatfish can be built successfully.

Comment 15

[Mason Chang [Inactive] [:mchang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/85c47751346a

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/85c47751346a