1094059 - [flatfish] build break by gecko/gfx/layers/ipc/CompositorParent.cpp:316

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: General, defect)

Description

[Danny Liang [:dliang]]

Attachment: build.log

There is build break by gecko/gfx/layers/ipc/CompositorParent.cpp:316 on flatfish, error log as following:

In file included from Unified_cpp_gfx_layers4.cpp:47:0:
../../../gecko/gfx/layers/ipc/CompositorParent.cpp: In member function 'void mozilla::layers::CompositorVsyncObserver::DispatchTouchEvents(mozilla::TimeStamp)':
../../../gecko/gfx/layers/ipc/CompositorParent.cpp:316:54: error: no matching function for call to 'mozilla::GeckoTouchDispatcher::NotifyVsync(mozilla::TimeStamp&)'
../../../gecko/gfx/layers/ipc/CompositorParent.cpp:316:54: note: candidate is:
../../../gecko/widget/gonk/GeckoTouchDispatcher.h:50:15: note: static bool mozilla::GeckoTouchDispatcher::NotifyVsync(uint64_t)
../../../gecko/widget/gonk/GeckoTouchDispatcher.h:50:15: note:   no known conversion for argument 1 from 'mozilla::TimeStamp' to 'uint64_t {aka long long unsigned int}'
In file included from Unified_cpp_gfx_layers4.cpp:137:0:
../../../gecko/gfx/layers/ipc/SharedBufferManagerParent.cpp: In member function 'void mozilla::layers::SharedBufferManagerParent::DropGrallocBufferImpl(mozilla::layers::SurfaceDescriptor)':
../../../gecko/gfx/layers/ipc/SharedBufferManagerParent.cpp:322:32: warning: ignoring return value of 'bool mozilla::layers::PSharedBufferManagerParent::SendDropGrallocBuffer(const MaybeMagicGrallocBufferHandle&)', declared with attribute warn_unused_result [-Wunused-result]
In file included from Unified_cpp_dom_svg8.cpp:2:0:
../../../gecko/dom/svg/nsSVGBoolean.cpp: In member function 'nsresult nsSVGBoolean::SetBaseValueAtom(const nsIAtom*, nsSVGElement*)':
../../../gecko/dom/svg/nsSVGBoolean.cpp:68:24: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
...
make[6]: *** [Unified_cpp_gfx_layers4.o] Error 1
make[6]: *** Waiting for unfinished jobs....

Comment 1

[Danny Liang [:dliang]]

This build break is caused by bug 1087048, you can revert below commit to avoid the build break.

commit 06b697f7a6f66b026c689eabd19491694488f121
Author: Mason Chang <[e-mail]>
Date:   Thu Oct 30 08:48:42 2014 -0700

    bug 1087048. Dispatch touch events after vsync aligned composites. r=benwa

Hi Mason, would you mind checking the build break on flatfish?

Comment 2

[Danny Liang [:dliang]]

Update SW version:
Gecko: c0265bde5c70b4f1b8cd4cf8a614733e58ff6123
Gaia: 6f96a078fef1e8ca2f71b07916eef4eb2ba64943

Comment 3

[Safwan Rahman (:safwan)]

It should be blocker bug as its breaking build of Flatfish

Comment 4

[Mason Chang [Inactive] [:mchang]]

Please test this again with the patch from bug 1094058.

Comment 5

[Danny Liang [:dliang]]

By my test, with the patch and do revert command of comment 10, flatfish can be built successfully.

Comment 6

[Mason Chang [Inactive] [:mchang]]

From comment 5, the patch in bug 1094058 fixes this error. Resolving this bug.