1094144 - Add a test that ensures test_play_*_video has the correct audio channel opened

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

See bug 1086662, comment 3:
"
I don't think that testing the sound or video is easily done, however perhaps as an addition to test_play_*_video you could check that the correct audio channel is being opened (but that'd be a separate bug).
"

This could be done with the use of "current_audio_channel":
Example:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/dialer/test_dialer.py#28

Comment 1

[Martijn Wargers (dead)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/26119

Comment 2

[Zac C (:zac)]

Comment on attachment 8522245 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26119

mostly r+ but jsut a small change will save a few lines of code and combine the logic better.

Comment 3

[Martijn Wargers (dead)]

Attachment: audio_channel2

Thanks, that's much cleaner.
Tested locally on device and desktop.

Comment 4

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 8526110 [details] [review]
audio_channel2

Echoed from PR so it's in Bugzilla.

Per conversation, please file a bug about self.data.layer.current_audio_channel stealing the context. Getters should never do that (or should cache/restore it if they have to).

With a comment added at the first usage including a quick explanation that context gets stolen and a TODO to that bug, looks good and r=me

Comment 5

[Martijn Wargers (dead)]

Ok, I filed bug 1109203 for that.

Comment 6

[Martijn Wargers (dead)]

I updated the pull request with a comment with the bug number, so this pull request can be merged too.

Comment 7

[Martijn Wargers (dead)]

Florin, could you perhaps merge this pull request (I'm still busy trying to get merge access)?

Comment 8

[Martijn Wargers (dead)]

I have merge capabilities myself now: https://github.com/mozilla-b2g/gaia/commit/41868e156bbb54c83cd88c9174c2caa9725574ef