Closed Bug 1094262 Opened 11 years ago Closed 10 years ago

(ios) Implement the Send To Extension UI

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
All
iOS 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fennec + ---

People

(Reporter: st3fan, Assigned: st3fan)

References

Details

(Whiteboard: noteworthy)

Attachments

(5 files, 2 obsolete files)

Action Extension Flow Step 1
209.16 KB, image/png
Details
Action Extension Flow Step 2
176.98 KB, image/png
Details
Action Extension Flow Step 3
88.53 KB, image/png
Details
emptySync.zip
8.25 KB, application/zip
Details
PR: https://github.com/mozilla/firefox-ios/pull/517
47 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review
Assignee: nobody → sarentz
Status: NEW → ASSIGNED
After some experimentation I have some bad news to share. It seems Action Extensions can only work full screen on phone devices. On tablet devices they can work either in fullscreen or in a pre-determined modal dialog that is centered above the application's greyed out transparent background. So this means that for Action Extensions, we cannot implement the design as shown in http://cl.ly/YNax (Share Extensions do not seem to have this limitation. I am not sure why there is a difference between the two.) I have attached three screenshots to this bug to show what the flow would look like with a full screen Action Extension.
So to be clear, we do have a full screen view controller that we can customize to our needs. In the third screenshot you can see that I added a tableviewcontroller in a navigationviewcontroller. We can do all the usual customization like cell headers, footers, more content, custom tint colors, fonts, etc. It just has to live in that full screen area.
Flags: needinfo?(randersen)
I will restyle this then. Thank you! What are our UI options for once you tap send? Success/Error cases?
Flags: needinfo?(randersen)
Summary: Implement the Send To Extension UI → (ios) Implement the Send To Extension UI
What happens happens after tapping send is not completely clear yet. I think ideally we just send the tab in the background and make the Action Extension UI go away as soon as possible. This is what most extensions seem to do. But it is not clear yet if that will be possible. We may be forced to do the sending while the Action Extension is still on screen, thus showing some feedback/progress. This won't be clear until later this month I think. (It depends on some technical details we have not fully figured out yet.) We do need a state for this Action Extension in case the user is not logged in yet: people need to log in to the app before the extensions work.
Attached file Pull Request (obsolete) —
Attachment #8520689 - Flags: review?(wjohnston)
Attachment #8520689 - Flags: review?(wjohnston)
Comment on attachment 8520689 [details] [review] Pull Request I'd like to move the code around a bit, but overall looks good.
Attachment #8520689 - Flags: review+
Attached file Pull Request (obsolete) —
Attachment #8520689 - Attachment is obsolete: true
Attachment #8520878 - Flags: review?(wjohnston)
I have updated the PR. It has been brought up to date with the current code base. Refactored most of the code so that it uses the AccountManager and (Data) Providers.
Flags: needinfo?(wjohnston)
Attachment #8520878 - Flags: review?(wjohnston) → review?(bnicholson)
Comment on attachment 8520878 [details] [review] Pull Request r=me with comments in PR.
Attachment #8520878 - Flags: review?(bnicholson) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Group: mozilla-employee-confidential
OS: All → iOS 7
Product: Firefox for Android → Firefox for iOS
Version: Trunk → unspecified
Reopening this because this is using an early version of the UI that needs to be revisited and updated
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
tracking-fennec: --- → ?
tracking-fennec: ? → +
Flags: needinfo?(wjohnston)
Yes, Stefan, those are the latest, thanks for digging them up! Will that work?
Depends on: 1164904
Flags: needinfo?(randersen)
Attached file emptySync.zip —
This patch brings the Send Tab UI up to date with the design at https://mozilla.invisionapp.com/share/VA2JQLFJ7#/screens/70030948?maintainScrollPosition=false It also contains a fix for bug 1164904 which makes sure your Firefox Account credentials are stored in a way so that they are shared with the extensions.
Attachment #8520878 - Attachment is obsolete: true
Attachment #8612463 - Flags: review?(sleroux)
Comment on attachment 8612463 [details] [review] PR: https://github.com/mozilla/firefox-ios/pull/517 Left some comments on the PR
Attachment #8612463 - Flags: review?(sleroux) → review+
Status: REOPENED → RESOLVED
Closed: 11 years ago → 10 years ago
Resolution: --- → FIXED
Whiteboard: noteworthy
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: