1094436 - SpeechRecognition::GetUserMediaSuccessCallback::OnSuccess leaks the argument stream

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Like so:

  DOMLocalMediaStream *localStream = nullptr;
  nsresult rv = CallQueryInterface(aStream, &localStream);

no localStream is holding a ref if the QI succeeded, and the ref is never released.

Please nominate this for blocking the relevant gecko releases.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

This code isn't enabled by default, so shouldn't block anything.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1094436.patch, v1

rjesup: Should be functionally identical to the patch in bug 994912 but but I figured out how to avoid the cast digging into our mailing list history :).

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e581cbe0d719

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8518154 [details] [diff] [review]
bug1094436.patch, v1

Review of attachment 8518154 [details] [diff] [review]:
-----------------------------------------------------------------

r+

Andre: does this work for you?

In any case, this is far more correct, so let's get it in

Comment 5

[Andre Natal]

(In reply to Randell Jesup [:jesup] from comment #4)
> Comment on attachment 8518154 [details] [diff] [review]
> bug1094436.patch, v1
> 
> Review of attachment 8518154 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r+
> 
> Andre: does this work for you?
> 
> In any case, this is far more correct, so let's get it in

Yes Randell, this works

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

re-try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=93cae3c9a278

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/133c7c11ec7f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/133c7c11ec7f