Closed Bug 1096078 Opened 5 years ago Closed 5 years ago
Restore Cycle collection use of Destroy() for DOMMedia
Stream if needed .
+++ This bug was initially created as a clone of Bug #994912 +++ Please restore the lost tmp->Destroy() (in place of bug 1078017's release of just the listener), or respond & resolve as to why it's not appropriate to do so.
Comment on attachment 8520062 [details] [diff] [review] bug1096078.patch, v1 successful tries: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=dfaddf47d85f https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0d4b7a166c09
Attachment #8520062 - Flags: review?(rjesup)
Attachment #8520062 - Flags: review?(rjesup) → review+
Please ask for uplift to 35 after this is in central (as bug 1078017 was uplifted to there, and also 2.2 if that's branched (I don't think so - check)).
Whiteboard: [priority] → [priority][webrtc-uplift]
2.2 isn't branching for awhile yet
Comment on attachment 8520062 [details] [diff] [review] bug1096078.patch, v1 Approval Request Comment [Feature/regressing bug #]: 994912 and 1078017 [User impact if declined]: Difficult to say. Fix in bug 1078017 appears to resolve the reported assertions, but since it solves the problem in a different way, it may be broken in other ways, where as this approach has been long tested. [Describe test coverage new/current, TBPL]: Existing mochitests appear to capture the condition (although they passed for 994912, may be intermittent) as from bug 1078017. Verified manually that no assertion was produced when recording videos and playing back content. [Risks and why]: Small given this is merely reverting in part to the way it historically worked without issue. [String/UUID change made/needed]: None.
Attachment #8520062 - Flags: approval-mozilla-aurora?
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Attachment #8520062 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.