1094753 - [Costcontrol] Changing the hash value for '#' does not maintain the correct hash on the app.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Marina Rodríguez [:mai]]

When the new hash is '#', the App does not calculate correctly hash. This is important because the application establishes the view using the hash.

Comment 1

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Comment 2

[Marina Rodríguez [:mai]]

Comment on attachment 8518101 [details] [review]
patch v1.0

Hi Salva,
would you mind reviewing the patch?
regards

Comment 3

[Salvador de la Puente González [:salva]]

Comment on attachment 8518101 [details] [review]
patch v1.0

I agree on you about the navigation system is vital. Due to this, please, refactor and expose the normalization process to allow it to be tested. I this becomes urgent, then we could move the tests to a follow up but since it's not blocking, let's do it now.

Ask for my review when tests are done, please.

Thank you!

Comment 4

[Marina Rodríguez [:mai]]

Comment on attachment 8518101 [details] [review]
patch v1.0

Added some tests to the PR

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 8518101 [details] [review]
patch v1.0

Tests are failing [1]. See other comments on GitHub.

Thank you.

[1] https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=19a7a96064ef

Comment 6

[Marina Rodríguez [:mai]]

Comment on attachment 8518101 [details] [review]
patch v1.0

Fixed the errors on the tests. The problem was located on a listener that was attached to the window, but it has not removed.

Comment 7

[Salvador de la Puente González [:salva]]

Comment on attachment 8518101 [details] [review]
patch v1.0

Looks great. Thank you :mai!

Comment 8

[Marina Rodríguez [:mai]]

Master: 65d593cdd9d88648045a30a63fc329b7bb5d340b