[Costcontrol] Changing the hash value for '#' does not maintain the correct hash on the app.

RESOLVED FIXED

Status

Firefox OS
Gaia::Cost Control
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mai, Assigned: mai)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
salva
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
When the new hash is '#', the App does not calculate correctly hash. This is important because the application establishes the view using the hash.
(Assignee)

Updated

3 years ago
Assignee: nobody → marina.rodrigueziglesias
(Assignee)

Comment 1

3 years ago
Created attachment 8518101 [details] [review]
patch v1.0
(Assignee)

Comment 2

3 years ago
Comment on attachment 8518101 [details] [review]
patch v1.0

Hi Salva,
would you mind reviewing the patch?
regards
Attachment #8518101 - Flags: review?(salva)
Comment on attachment 8518101 [details] [review]
patch v1.0

I agree on you about the navigation system is vital. Due to this, please, refactor and expose the normalization process to allow it to be tested. I this becomes urgent, then we could move the tests to a follow up but since it's not blocking, let's do it now.

Ask for my review when tests are done, please.

Thank you!
Attachment #8518101 - Flags: review?(salva)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8518101 [details] [review]
patch v1.0

Added some tests to the PR
Attachment #8518101 - Flags: review?(salva)
Comment on attachment 8518101 [details] [review]
patch v1.0

Tests are failing [1]. See other comments on GitHub.

Thank you.

[1] https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=19a7a96064ef
Attachment #8518101 - Flags: review?(salva) → review-
(Assignee)

Comment 6

3 years ago
Comment on attachment 8518101 [details] [review]
patch v1.0

Fixed the errors on the tests. The problem was located on a listener that was attached to the window, but it has not removed.
Attachment #8518101 - Flags: review- → review?(salva)
Comment on attachment 8518101 [details] [review]
patch v1.0

Looks great. Thank you :mai!
Attachment #8518101 - Flags: review?(salva) → review+
(Assignee)

Comment 8

3 years ago
Master: 65d593cdd9d88648045a30a63fc329b7bb5d340b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Blocks: 1098024
(Assignee)

Updated

3 years ago
No longer blocks: 1098024
You need to log in before you can comment on or make changes to this bug.