Closed Bug 1094761 Opened 5 years ago Closed 4 years ago
e10s - fix browser
_context Search Tab Position to not hit the network in e10s mode
MozReview Request: Bug 1094761 - Fix browser_contextSearchTabPosition.js to not hit the network. r=Florian
58 bytes, text/x-review-board-request
It looks like the test depends on removing the tabs cancelling the network requests, which seems like it's not the case in e10s, which means sometime during the next test or two that runs (!), we crash due to outside network requests when run on our infra: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6d095d99d129 We can workaround by using a fake search provider (see bug 1062096 on some of the machinery of how to do that) and/or stopping the network request in a more efficient way...
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Review commit: https://reviewboard.mozilla.org/r/35025/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/35025/
Attachment #8719599 - Flags: review?(florian)
I forgot to save the removal of this test from browser/base/content/test/general/browser.ini, but I updated my patch locally to do it.
Attachment #8719599 - Flags: review?(florian) → review+
Comment on attachment 8719599 [details] MozReview Request: Bug 1094761 - Fix browser_contextSearchTabPosition.js to not hit the network. r=Florian https://reviewboard.mozilla.org/r/35025/#review31561 ::: browser/components/search/test/browser.ini:25 (Diff revision 1) > +skip-if = os == "mac" Please keep the "# bug 967013" comment here.
You need to log in before you can comment on or make changes to this bug.