Closed Bug 1094761 Opened 5 years ago Closed 4 years ago

e10s - fix browser_contextSearchTabPosition to not hit the network in e10s mode

Categories

(Firefox :: Search, defect, P4)

defect
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
e10s + ---
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: Gijs, Assigned: Felipe)

References

(Blocks 1 open bug)

Details

(Whiteboard: [e10s test][fxsearch])

Attachments

(1 file)

It looks like the test depends on removing the tabs cancelling the network requests, which seems like it's not the case in e10s, which means sometime during the next test or two that runs (!), we crash due to outside network requests when run on our infra:

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6d095d99d129


We can workaround by using a fake search provider (see bug 1062096 on some of the machinery of how to do that) and/or stopping the network request in a more efficient way...
Flags: qe-verify-
Flags: in-testsuite+
Flags: firefox-backlog+
Rank: 43
Priority: -- → P4
Whiteboard: [e10s test][fxsearch]
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Duplicate of this bug: 1248484
I forgot to save the removal of this test from browser/base/content/test/general/browser.ini, but I updated my patch locally to do it.
Attachment #8719599 - Flags: review?(florian) → review+
Comment on attachment 8719599 [details]
MozReview Request: Bug 1094761 - Fix browser_contextSearchTabPosition.js to not hit the network. r=Florian

https://reviewboard.mozilla.org/r/35025/#review31561

::: browser/components/search/test/browser.ini:25
(Diff revision 1)
> +skip-if = os == "mac"

Please keep the "# bug 967013" comment here.
https://hg.mozilla.org/mozilla-central/rev/829d5a1b43cc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.