1094761 - e10s - fix browser_contextSearchTabPosition to not hit the network in e10s mode

Status: RESOLVED FIXED

(Firefox :: Search, defect, P4)

Description

[:Gijs (he/him)]

It looks like the test depends on removing the tabs cancelling the network requests, which seems like it's not the case in e10s, which means sometime during the next test or two that runs (!), we crash due to outside network requests when run on our infra:

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6d095d99d129


We can workaround by using a fake search provider (see bug 1062096 on some of the machinery of how to do that) and/or stopping the network request in a more efficient way...

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: MozReview Request: Bug 1094761 - Fix browser_contextSearchTabPosition.js to not hit the network. r=Florian

Review commit: https://reviewboard.mozilla.org/r/35025/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35025/

Comment 3

[:Felipe Gomes (needinfo for replies!)]

I forgot to save the removal of this test from browser/base/content/test/general/browser.ini, but I updated my patch locally to do it.

Comment 4

[Florian Quèze [:florian] (on leave until October 9)]

Comment on attachment 8719599 [details]
MozReview Request: Bug 1094761 - Fix browser_contextSearchTabPosition.js to not hit the network. r=Florian

https://reviewboard.mozilla.org/r/35025/#review31561

::: browser/components/search/test/browser.ini:25
(Diff revision 1)
> +skip-if = os == "mac"

Please keep the "# bug 967013" comment here.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/829d5a1b43cc

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/829d5a1b43cc

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0f276504c5d0