1094844 - Use new keywords API in search service

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

it's currently using getURIForKeyword to check if the user is inserting a search keyword duplicate of a bookmarks keyword.

The problem is that editKeyword is synchronous, but I guess we could make it async, since it's only used by a command.

(honestly I'm not sure if that still makes sense, we could just decide a keywords priority in unified complete and let the user create dupes...)

Comment 1

[Marco Bonardo [:mak]]

/browser/components/search/content/engineManager.js (View Hg log or Hg annotations)

    line 127 -- if (bmserv.getURIForKeyword(alias.value))

see also bug 1148457

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch v1

This was easier than expected

Comment 3

[Marco Bonardo [:mak]]

Note, I tested this manually with in-content prefs, old prefs and old search ui.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8590863 [details] [diff] [review]
patch v1

Review of attachment 8590863 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/search/content/engineManager.xul
@@ +35,5 @@
>      <command id="cmd_movedown"
>               oncommand="gEngineManagerDialog.bump(-1);"
>               disabled="true"/>
>      <command id="cmd_editkeyword"
> +             oncommand="gEngineManagerDialog.editKeyword().catch(Cu.reportError);"

self-comment: I should use Components.utils rather than Cu.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/75afd4419cd3

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/75afd4419cd3