Closed Bug 1068034 Opened 5 years ago Closed 5 years ago

breakdown: convert consumers to the new async bookmarking API

Categories

(Toolkit :: Places, defect)

defect
Not set
Points:
3

Tracking

()

RESOLVED FIXED
mozilla36
Iteration:
36.2

People

(Reporter: mak, Assigned: mak)

References

(Blocks 1 open bug)

Details

Need to identify all consumers of the bookmarking API and file single bugs for each of them.
Depends on: 1068015
Blocks: 1068054
Flags: qe-verify-
Flags: firefox-backlog+
Hey Marco, can you flesh out that description a bit? A good first bug that amounts to "file more bugs" would be pretty easy to farm out, I'd think.
Flags: needinfo?(mak77)
I think it's a little bit more complex than that, cause the bugs should likely be filed by feature, rather than by code module (it's not enough to have a bug stating source.js uses such API, but we need "feature X uses such API").
Unfortunately that requires some internal knowledge of the Places features and how they are spread into the product.

For example one bug might be "Update the star button to use Bookmarks.jsm"... but while that one is a very prominent piece of code, there may be others less clear like "replace all consumers of asyncGetBookmarkIds and deprecate it".

I'm not sure it's easy to achieve thatwithout internals knowledge.

Btw, the whole description here is: For each API implemented in nsINavBookmarksService, identify the call points, group them by features or code-blocks and file a bug to convert each feature/group.
Flags: needinfo?(mak77)
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Iteration: --- → 36.2
No longer blocks: 1068054
Depends on: 1068054
Depends on: 1094812
Depends on: 1094818
Depends on: 1094832
Depends on: 1094844
Depends on: 1094875
Depends on: 1094876
Depends on: 1094882
Depends on: 1094886
Depends on: 1094888
Depends on: 1094900
Depends on: 1095405
Depends on: 1095406
Depends on: 1095408
Depends on: 1095411
Depends on: 1095424
Depends on: 1095425
Depends on: 1095426
Depends on: 1095427
breakdown is complete, I also did the same for Bug 1068032, since it also needed some splitting.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Depends on: 1148457
No longer depends on: 1148457
Depends on: 1379611
You need to log in before you can comment on or make changes to this bug.