1095128 - Intermittent failures in add-ons manager mochitest-browser tests

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

Looks like bug 1080785 caused a surge of intermittent failures in various xpinstall tests. Worth looking at these as a group I think.

Comment 1

[Dave Townsend [:mossop]]

Not xpinstall at all, in fact three of these failures are all caused by the same problem

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch

The test harness disables add-on updates so the background update running during tests doesn't mess things up. Unfortunately browser_bug557956.js opens the compatibility UI which has the side effect of turning add-on updates on so for most of the browser chrome tests add-on updates are enabled.

The four dependencies at least look to be caused by this, you can tell because for the period when background updates were broken by bug 1090450 they all stopped showing up.

I've just added a couple of the update prefs to those to be restored at the end of every run to make sure no other tests do this by accident.

Comment 3

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/fx-team/rev/121a5cc63382

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/121a5cc63382

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr31/rev/5457356eada0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f86e6af6c3ac
https://hg.mozilla.org/releases/mozilla-beta/rev/9fd2eb476533