1095219 - Failing unit test, smart-home-test/unit/card_manager_test.js | Uncaught Error: ReferenceError: evt is not defined

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

1) [smart-home-test/unit/card_manager_test.js] smart-home/CardManager "before all" hook:
     Uncaught Error: ReferenceError: evt is not defined (app://smart-home.gaiamobile.org/js/card_manager.js?time=1415320658875:9)
      at onerror (app://smart-home.gaiamobile.org/common/vendor/mocha/mocha.js:4959:10)

Likely caused by bug 1093436.

Comment 1

[Kevin Grandon :kgrandon]

Disabled for now for being perma red: https://github.com/mozilla-b2g/gaia/commit/2eab7a4ca9b6196e429623ce39c4dae1368ecb84

John - can you take a look at this? I'm wondering if there's some magic we need to do to support the tv_shared path.

Comment 2

[Kevin Grandon :kgrandon]

Changed disabling strategy, as it seemed it could still be failing due to includes throwing errors, https://github.com/mozilla-b2g/gaia/commit/e0c1beb76148ee539ff00f7f84194dd5458c09f2

Comment 3

[Tzu-Lin Huang [:dwi2][:tzhuang]]

I could fix this.

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

Hi John,

Please help to review the patch. Thanks

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8518617 [details] [review]
pull request

It looks good to me. But we should wait for clear information about why others will fail with this test.

IIRC, we don't run the unit tests which is not built into profile folder. If this correct, the tests of smart-home only run at TV build. And we don't have any CI runs with TV build.

Ricky, I am not sure about which unit tests will be run at phone build. Do we run the tests under TV build?

BTW, this is for Kevin:

We use app's build script do the magic like webapps-shared.js does. We had created a tv_build/tv_shared_helper.js. All apps who uses any thing in tv_shared should include this helper file in its build script, build/build.js. It just scans html/css files and copies the used files to app's build_stage folder.

Comment 6

[Kevin Grandon :kgrandon]

So currently these tests are being run on taskcluster, and also fail when running on b2g desktop. I'm assuming that the problem is that the taskcluster is running them, and maybe it should not be?

Comment 7

[Kevin Grandon :kgrandon]

Here are the errors, you can see this failing in the 'GU21' chunk: https://treeherder.allizom.org/ui/#/jobs?repo=gaia&revision=8fa4a3e5ed2db23e9f34e71a5fd0b364a99817a8

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Test-agent doesn't concern profile folder. However, it tries to search whole gaia/ folder and find out those tests which match the path '*/test/unit/*' and '*_test.js'.

So I saw GAIA_ALLAPPDIR is included 'tv_apps', it should run tv unit testing in Gu.

Comment 9

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8518617 [details] [review]
pull request

Hi all,

I think we should disable tv_apps/ unit tests in all CI. But I'll like them to run locally somewhat easily.

I rename the unit test folder name. Then it won't be include in dev_apps/test-agent/config.json

Comment 10

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8518617 [details] [review]
pull request

It looks fine to me.

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8518617 [details] [review]
pull request

Seems like you have some reviews, so that's fine by me.

Comment 12

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Gaia-Try result is good 
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=e9026c0e97ba

Landed on master
https://github.com/mozilla-b2g/gaia/commit/68c8c5a78e208672a1c30254c77bbfb0f9b67ffe