enable content worker tests in an e10s test addon

RESOLVED FIXED in mozilla37

Status

P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: zombie, Assigned: zombie)

Tracking

(Blocks: 1 bug)

unspecified
mozilla37
Dependency tree / graph

Firefox Tracking Flags

(e10s+)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
include test-content-worker-parent, test-page-mod, and anything else as it gets switched to use the new content worker..

this is blocked on switching to mochitestification test suite..
(Assignee)

Updated

4 years ago
Blocks: 1066685
Blocks: 984139
tracking-e10s: --- → +
(Assignee)

Updated

4 years ago
Assignee: nobody → tomica+amo
Status: NEW → ASSIGNED
Priority: -- → P1
(Assignee)

Comment 1

4 years ago
Created attachment 8541878 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1774

> this is blocked on switching to mochitestification test suite..

i figured i can proceed without waiting for this:
1) our current test suite can handle e10s addons just fine
2) i can just skip-if this for mochitests, until we solve that part


(i plan to add other content worker related tests files to this addon one by one)
Attachment #8541878 - Flags: review?(dtownsend)
Comment on attachment 8541878 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1774

Is this just a copy of the tests from the main suite? At some point maybe we can just remove the tests in the main suit then run this one add-on in both non-e10s and e10s modes then we don;t have to have the tests in two places.
Attachment #8541878 - Flags: review?(dtownsend) → review+

Comment 3

4 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e01cacf68f7bf499b0ab11be912af7fe8232a9d9
bug 1095442 - enable content worker tests in e10s mode

https://github.com/mozilla/addon-sdk/commit/2ec89f13dda3e32e3379bf36627eb8ff1d39f41c
Merge pull request #1774 from zombie/1095442-e10s-content-tests

bug 1095442 - enable content worker tests in e10s mode, r=@Mossop
(Assignee)

Comment 4

4 years ago
(In reply to Dave Townsend [:mossop] from comment #2)
> Is this just a copy of the tests from the main suite? At some point maybe we
> can just remove the tests in the main suit then run this one add-on in both
> non-e10s and e10s modes then we don;t have to have the tests in two places.

yeah, i have a vague plan to do something like that, which i hope crystallizes by the time we have the majority of package tests passing in e10s mode.
Blocks: 1004745
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
(Assignee)

Updated

4 years ago
Depends on: 1116544
You need to log in before you can comment on or make changes to this bug.