1116544 - switch remaining tests to new content/worker

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Comment 1

[Tomislav Jovanovic :zombie]

the remaining tests are test-content-script.js and addons/unsafe-content-script.

Comment 2

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1782

split into two (logical) commits, to make the changes clearer.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/4505259d0bc52f91dc198e0566677e9292cc0871
bug 1116544 - switch remaining test to use the new content/worker

https://github.com/mozilla/addon-sdk/commit/6d0d079b40b7d1e1c02a16e770d0223c4d388c47
bug 1116544 - add test-content-script.js to e10s-content test addon

https://github.com/mozilla/addon-sdk/commit/96f94e44d9955358fc8ae6f96516aebba1cac707
Merge pull request #1782 from zombie/1116544-switch-tests

bug 1116544 - switch remaining tests to new content/worker, r=@Mossop

Comment 4

[Bobby Holley (:bholley)]

This patch seems to introduce new usage of __exposedProps__, which is forbidden. Can you explain what you're trying to do here?

Comment 5

[Tomislav Jovanovic :zombie]

heh, i remember you have a commit hook for this Bobby.  ;)

1) this patch is a test-only change, and 
2) there is no new code in this patch. 

this only switches test-content-script.js to use the new (e10s-compatible) Worker, and copies that file to test/addons/e10s-content.

the reason behind is long and boring, but boils down to: that's the only way we can currently run some of our tests in e10s mode. it's a temporary thing, and i expect we will be able to delete all e10s-* test addons in a month of few, when we find a better way to do that.

hope that's a satisfactory answer.

Comment 6

[Bobby Holley (:bholley)]

(In reply to Tomislav Jovanovic [:zombie] from comment #5)
> heh, i remember you have a commit hook for this Bobby.  ;)
> 
> 1) this patch is a test-only change, and 
> 2) there is no new code in this patch. 
> 
> this only switches test-content-script.js to use the new (e10s-compatible)
> Worker, and copies that file to test/addons/e10s-content.

Oh I see - so this is a pre-existing test that's being duplicated? In that case that's fine.