Closed Bug 1095602 Opened 5 years ago Closed 11 months ago
remove the STATE
_SECURE _HIGH, STATE _SECURE _MEDIUM, STATE _SECURE _LOW distinction from ns IWeb Progress Listener
47 bytes, text/x-phabricator-request
|Details | Review|
According to the documentation in nsIWebProgressListener.idl, if the state is STATE_IS_SECURE, the level of security is described by one of STATE_SECURE_HIGH, STATE_SECURE_MEDIUM, or STATE_SECURE_LOW. However, in the actual implementation, we only ever use STATE_SECURE_HIGH. In any case, the distinction is unhelpful; either you're using strong, known-secure encryption and we can reasonably say a connection is secure, or you're not, and we can't say it's secure at all. We should just remove any classification of this sort and rely on STATE_IS_SECURE vs. STATE_IS_INSECURE vs. STATE_IS_BROKEN (which, again, the implementation actually already does).
I think we're almost out of these state flag values when bug 1504728 lands, so fixing this could be a nice way to get three more flag values back...
Only STATE_SECURE_HIGH is used, and that's only in instances where STATE_IS_SECURE is also used, so we can remove the security level flags and just assume STATE_IS_SECURE is also STATE_SECURE_HIGH.
Was doing some docshell triage and saw this, and it fits in with my work on bug 1503630, so figured I'd take care of it real quick.
Assignee: nobody → kyle
Priority: -- → P2
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b83cac4f938a Remove STATE_SECURE flags from nsIWebProgressListener; r=Ehsan
10 months ago
Depends on: 1527036
You need to log in before you can comment on or make changes to this bug.