ReferenceError: reference to undefined property "STATE_SECURE_HIGH" in specialTabs.js:151:1

RESOLVED FIXED in Thunderbird 67.0

Status

enhancement
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 67.0

Thunderbird Tracking Flags

(thunderbird66 fixed, thunderbird67 fixed)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

3 months ago

Opening Help->Troubleshooting info I get:
ReferenceError: reference to undefined property "STATE_SECURE_HIGH" in specialTabs.js:151:1

Looks like STATE_SECURE_HIGH constant does not exist anymore in m-c.
See
https://searchfox.org/comm-central/search?q=STATE_SECURE&case=false&regexp=false&path= these constants are aonly used in c-c a multiple places. This needs some update.

Trangely the STATE_SECURE_* constants are still mentioned in m-c comment at https://searchfox.org/comm-central/source/mozilla/uriloader/base/nsIWebProgressListener.idl#171 , but defined nowhere.

Looks like bug 1095602.

(Assignee)

Comment 1

2 months ago
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #9042742 - Flags: ui-review?(richard.marti)
Attachment #9042742 - Flags: review?(philipp)
Attachment #9042742 - Flags: review?(mkmelin+mozilla)
Attachment #9042742 - Flags: review?(frgrahl)
Comment on attachment 9042742 [details] [diff] [review]
1525834.patch [landed in comment #7 without the Calendar hunks]

Could the attributes be "secure" and "insecure" instead of "secure" and "broken"?
Attachment #9042742 - Flags: ui-review?(richard.marti) → ui-review+
(Assignee)

Comment 3

2 months ago

According to https://searchfox.org/comm-central/source/mozilla/uriloader/base/nsIWebProgressListener.idl#156 "insecure" and "broken" are different states. I think the patch keeps all 3 states distinguished (insecure sets no level and hides securitybutton, e.g. https://searchfox.org/comm-central/source/mail/base/content/browserRequest.js#71).

Depends on: 1095602
Comment on attachment 9042742 [details] [diff] [review]
1525834.patch [landed in comment #7 without the Calendar hunks]

Looks good Thanks+++

IanN: No change needed for the status bar I think. Only uses high.
Attachment #9042742 - Flags: review?(philipp) → review+
Comment on attachment 9042742 [details] [diff] [review]
1525834.patch [landed in comment #7 without the Calendar hunks]

Upps set wrong reviewer
Attachment #9042742 - Flags: review?(frgrahl) → review?(philipp)
Attachment #9042742 - Flags: review?(mkmelin+mozilla) → review+

Comment 6

2 months ago

I don't think the gData bit is right. gData tries to maintain compatibility with earlier versions of TB. You might also want to ask MMD for review. I'm going to land the non-Calendar bits now.

Keywords: leave-open

Comment 7

2 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/25a47ea601f0
Port bug 1095602: Remove STATE_SECURE flags from nsIWebProgressListener. r=mkmelin,frg ui-r=Paenglab

Updated

2 months ago
Target Milestone: --- → Thunderbird 67.0
(Assignee)

Comment 8

2 months ago

Yes, thanks.

Attachment #9042769 - Flags: review?(philipp)
(Assignee)

Updated

2 months ago
Attachment #9042742 - Flags: review?(philipp)

Updated

2 months ago
Attachment #9042742 - Attachment description: 1525834.patch → 1525834.patch [landed in comment #7 without the Calendar hunks]
Comment on attachment 9042769 [details] [diff] [review]
1525834-cal.patch

Review of attachment 9042769 [details] [diff] [review]:
-----------------------------------------------------------------

Generally you are right, I try to maximize the compatibility for gdata. In this case I think it is fine nevertheless, the new code works with the old m-c code as well, we are just a bit less granular.
Attachment #9042769 - Flags: review?(philipp) → review+

Comment 10

2 months ago

Right, reading bug 1095602 comment #0 and https://hg.mozilla.org/mozilla-central/rev/b83cac4f938a, there was only ever a combination of "secure + high" used. "High" didn't occur alone and the other two were never used. I'll get this landed.

Comment 11

2 months ago
Comment on attachment 9042769 [details] [diff] [review]
1525834-cal.patch

Gotta love the spurious "y" at the end of the patch :-)

Updated

2 months ago
Attachment #9042742 - Flags: approval-comm-beta+

Updated

2 months ago
Attachment #9042769 - Flags: approval-comm-beta+

Comment 12

2 months ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/6eac5062e8a1
Port bug 1095602: Remove STATE_SECURE flags from nsIWebProgressListener in calendar/. r=philipp

Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.