1095626 - Transition flow makes splitting the Register/Sign in flows moot

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[krupa raj[:krupa]]

We split up the registration and sign in flows to be separate. However, currently choosing any flow involves the user go through the exact same steps

1. User clicks Register
2. We prompt them to enter their email ID
3. Based on their email id, we figure out what flow to send them to next

1. User clicks Sign in
2. We prompt them to enter their email ID
3. Based on their email id, we figure out what flow to send them to next

Right now, there isn't much point to having two separate links to register and sign in.

Comment 1

[Mark Striemer [:mstriemer]]

Looking at the lucidchart [1] this is what we expect to happen.

Ryan, should this go straight to FxA register and skip our migration info step? Currently the two buttons will have the same behaviour while the migration is active, only the email the user enters will have an affect on where they land on FxA.

[1] https://www.lucidchart.com/documents/view/769cc8ee-64c7-456c-aceb-c4c6a43929dd/0

Comment 2

[Ryan Feeley [:rfeeley]]

There is a reason, and if I recall correctly, it's so that we can handle some downstream cases. Please review the flows carefully.

IIRC it had to do something with the users accidentally clicking one action (e.g. login) but intending to use the other (e.g. register).

Comment 3

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/marketplace-core-modules/pull/9
https://github.com/mozilla/fireplace/pull/827

Comment 4

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/marketplace-core-modules/commit/6c52364dd7e87bc9ae24c886fe23a5d3667612f0
https://github.com/mozilla/fireplace/commit/200bfbdec85f83d58fb528c60cd8a1668d01f93e
https://github.com/mozilla/fireplace/commit/0bf7b2566f09bba63f75a8904e61ee28cf55bcc9

Comment 5

[Madalin Cotetiu]

Verified as fixed on FF37(Win 7) and FFOS 2.0(Flame) on https://marketplace-dev.allizom.org/
Postfix screencast http://screencast.com/t/Gl3rBdTu
Closing bug.