109584 - Ctrl+L in minimal chrome mode does nothing

Status: RESOLVED INVALID

(SeaMonkey :: General, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Steps to reproduce:
1) Enter minimal chrome mode (hit F11)
2) Hit Ctrl+L

Expected behaviour:
either: 
1) open location dialog appears
2) url bar appears temporarily
3) some other means of entering a new URL

I'm aware Ctrl+Shift+L still brings up the Open Location dialog, but it seems 
to me that Ctrl+L should continue to operate.

Comment 1

[Stephen P. Morse]

> it seems to me that Ctrl+L should continue to operate.

When did ctrl-L ever operate that way.  Our menu item lists the shortcut for 
open web location as ctrl-shift-L.  That's true for full-screen mode as well as 
normal screen mode.

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Ctrl+L focuses the urlbar and selects its content. 

Since in minimal chrome mode there is no urlbar, when Ctrl+L is hit, there are 
two options: 

- rebind to showing the open location dialog
- temporarily show the location bar, and select its contents, hiding it again 
when the user is done with it. 

Comment 3

[Stephen P. Morse]

Neat feature.  I wasn't aware of it.

Is their currently any discovery mechanism for ctrl-L?

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Not really, other than the fact it's been a known way of invoking some sort of 
open location in the past...

Our current implementation matches that of Internet Explorer on the Mac, which 
focuses the URLBar rather than opening a dialog, which can be slightly faster 
(from both perceptual and actual points of view). 

If we could persuade Joe into making slim line URLBar styles when he's doing 
the tbstyle stuff for the buttons, we could potentially leave the urlbar 
visible in this mode, providing it didn't excessively increase the height of 
the toolbar. What do you think? 

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

(That would also have the effect of fixing a focus issue I discovered when 
opening a new window in full screen mode... focus gets trashed because the init 
code in the browser tries to focus the hidden urlbar.. which causes focus to go 
away to la la land and you have to click the content area before any 
keybindings/arrow navigation etc work again) 

Comment 6

[Stephen P. Morse]

Thanks, you just solved a problem for me.  I saw that problem with loss of 
keybindings when I was implementing full-screen mode but didn't understand what 
was causing it.  And someone has already filed a bug report on that (bug 109627) 
which I'll copy you on.

Regarding slim urlbar, sounds like a good idea.

Comment 7

[Neil Pryde]

You might have a look at the MultiZilla MaxMode function, it's very handy, with
a slimline urlbar. A lot of people seem to use it.

Comment 8

[:deanis74]

The first "full-screen" mode was backed out for bug 109593, and bug 68136 has
since been fixed properly.  This bug is no longer valid.