Closed Bug 1096194 Opened 10 years ago Closed 10 years ago

[woodduck] Responding Enhanced call control with ERROR if enhanced call control is not supported

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

defect
Not set
normal

Tracking

(blocking-b2g:2.0M+, b2g-v2.0 wontfix, b2g-v2.0M fixed, b2g-v2.1 ?, b2g-v2.2 fixed)

RESOLVED FIXED
2.1 S9 (21Nov)
blocking-b2g 2.0M+
Tracking Status
b2g-v2.0 --- wontfix
b2g-v2.0M --- fixed
b2g-v2.1 --- ?
b2g-v2.2 --- fixed

People

(Reporter: shawnjohnjr, Assigned: shawnjohnjr)

References

Details

(Whiteboard: [blueangel])

Attachments

(2 files, 7 obsolete files)

3.09 KB, patch
Details | Diff | Splinter Review
1.66 KB, patch
Details | Diff | Splinter Review
Responding Enhanced call control with ERROR if enhanced call control is not supported
Assignee: nobody → shuang
Hi Shawn,
Is this generic or 2.0M only? Do you like to nominate to 2.0M? Thanks!
Blocks: Woodduck
Flags: needinfo?(shuang)
(In reply to Josh Cheng [:josh] from comment #1)
> Hi Shawn,
> Is this generic or 2.0M only? Do you like to nominate to 2.0M? Thanks!

CAF bluedroid already disabled enhanced call control, so enhanced call control won't be bypassed to CallHoldNotification. However, blueangel bypass enhanced call control, so callback CallHoldNotification still be executed. We shall check and guard "Release Specified Call Index" behavior.
Flags: needinfo?(shuang)
Meanwhile, I don't see any reason we should not support enhanced call control here. Open an another bug for this feature.
blocking-b2g: --- → 2.0M?
Whiteboard: [ETA:11/11][blueangel][2.0M only]
I think it's not necessary to commit this patch to v2.0. But I will make patch for m-c branch anyway.
blocking-b2g: 2.0M? → 2.0M+
Hi Ben,
This impact PTS test cases TC_AG_ECC_BI_03_I, TC_AG_ECC_BI_04_I
Attachment #8520433 - Attachment is obsolete: true
Attachment #8520433 - Flags: review?(btian)
Comment on attachment 8520448 [details] [diff] [review]
Bug 1096194 - [woodduck] Responding Enhanced call control with ERROR if enhanced call control is not supported

Review of attachment 8520448 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed. Thanks.

::: dom/bluetooth/bluedroid/hfp/BluetoothHfpManager.cpp
@@ +202,5 @@
>  
> +static bool
> +IsSupportedChld(const int aChld) {
> +  // We currently only support CHLD=0~3.
> +  return (aChld >=0 && aChld <= 3);

nit: space before 0

@@ +625,5 @@
>  BluetoothHfpManager::ProcessAtChld(bthf_chld_type_t aChld)
>  {
> +  if (!IsSupportedChld((int)aChld)) {
> +    // We currently don't support Enhanced Call Control.
> +    // AT+CHLD=1x or AT+CHLD=2x will be ignored

Replace 'or' with 'and' since both of them are ignored, not either of them.
Attachment #8520448 - Flags: review?(btian) → review+
Attachment #8520542 - Attachment description: bug1096194-mc.patch → Bug 1096194 - Responding Enhanced Call Control with ERROR if Enhanced Call Control is not supported, r=btian [m-c]
Attachment #8520554 - Attachment description: Bug 1096194 - Responding Enhanced Call Control with ERROR if Enhanced Call Control is not supported, r=btian → Bug 1096194 - Responding Enhanced Call Control with ERROR if Enhanced Call Control is not supported, r=btian [2.0m]
Whiteboard: [ETA:11/11][blueangel][2.0M only] → [ETA:11/11][blueangel]
https://hg.mozilla.org/mozilla-central/rev/e59e29b14cd6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Does this need to land on v2.1 as well?
status-b2g-v2.1: --- → ?
Flags: needinfo?(shuang)
Whiteboard: [ETA:11/11][blueangel] → [blueangel]
Target Milestone: --- → 2.1 S9 (21Nov)
Currently only woooduck platform can reproduce this bug due to different bluetooth back-end behavior. So I think it's better to phase in v2.1.
Flags: needinfo?(shuang)
Hi Shawn,
    Could you provide steps to help with our verification? Thanks very much.
Flags: needinfo?(shuang)
They are PTS test cases: TC_AG_ECC_BI_03_I, TC_AG_ECC_BI_04_I.
The handsfree device has to send AT command AT+CHLD=21 or AT+CHLD=12 to verify Enhanced Call Control.
If you need to test it, you need to have PTS or any handsfree headset/car kit can handle Enhanced call control.
Flags: needinfo?(shuang)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: