1096194 - [woodduck] Responding Enhanced call control with ERROR if enhanced call control is not supported

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Responding Enhanced call control with ERROR if enhanced call control is not supported

Comment 1

[Josh Cheng [:josh]]

Hi Shawn,
Is this generic or 2.0M only? Do you like to nominate to 2.0M? Thanks!

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Josh Cheng [:josh] from comment #1)
> Hi Shawn,
> Is this generic or 2.0M only? Do you like to nominate to 2.0M? Thanks!

CAF bluedroid already disabled enhanced call control, so enhanced call control won't be bypassed to CallHoldNotification. However, blueangel bypass enhanced call control, so callback CallHoldNotification still be executed. We shall check and guard "Release Specified Call Index" behavior.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Meanwhile, I don't see any reason we should not support enhanced call control here. Open an another bug for this feature.

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I think it's not necessary to commit this patch to v2.0. But I will make patch for m-c branch anyway.

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: bug1096194.patch

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

See also: bug 1096264 for tracking m-c.

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1096194 - [woodduck] Responding Enhanced call control with ERROR if enhanced call control is not supported

Comment 8

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Hi Ben,
This impact PTS test cases TC_AG_ECC_BI_03_I, TC_AG_ECC_BI_04_I

Comment 9

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: bug1096194.patch

Comment 10

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1096194 - [woodduck] Responding Enhanced call control with ERROR if enhanced call control is not supported

Comment 11

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: bug1096194-mc.patch

Comment 12

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: bug1096194-mc.patch

Comment 13

[Ben Tian (inactive)]

Comment on attachment 8520448 [details] [diff] [review]
Bug 1096194 - [woodduck] Responding Enhanced call control with ERROR if enhanced call control is not supported

Review of attachment 8520448 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed. Thanks.

::: dom/bluetooth/bluedroid/hfp/BluetoothHfpManager.cpp
@@ +202,5 @@
>  
> +static bool
> +IsSupportedChld(const int aChld) {
> +  // We currently only support CHLD=0~3.
> +  return (aChld >=0 && aChld <= 3);

nit: space before 0

@@ +625,5 @@
>  BluetoothHfpManager::ProcessAtChld(bthf_chld_type_t aChld)
>  {
> +  if (!IsSupportedChld((int)aChld)) {
> +    // We currently don't support Enhanced Call Control.
> +    // AT+CHLD=1x or AT+CHLD=2x will be ignored

Replace 'or' with 'and' since both of them are ignored, not either of them.

Comment 14

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1096194 - Responding Enhanced Call Control with ERROR if Enhanced Call Control is not supported, r=btian [m-c]

Comment 15

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1096194 - Responding Enhanced Call Control with ERROR if Enhanced Call Control is not supported, r=btian [2.0m]

Comment 16

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1096194 - Responding Enhanced Call Control with ERROR if Enhanced Call Control is not supported, r=btian [2.0m]

Comment 17

[Kai-Zhen Li [:seinlin][:kli]]

http://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/acd4d3b04191

Comment 18

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e59e29b14cd6

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e59e29b14cd6

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Does this need to land on v2.1 as well?

Comment 21

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Currently only woooduck platform can reproduce this bug due to different bluetooth back-end behavior. So I think it's better to phase in v2.1.

Comment 22

[Coler]

Hi Shawn,
    Could you provide steps to help with our verification? Thanks very much.

Comment 23

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

They are PTS test cases: TC_AG_ECC_BI_03_I, TC_AG_ECC_BI_04_I.
The handsfree device has to send AT command AT+CHLD=21 or AT+CHLD=12 to verify Enhanced Call Control.
If you need to test it, you need to have PTS or any handsfree headset/car kit can handle Enhanced call control.