1096572 - [Building Blocks] Update some RTL styles to match latest RTL spec

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[James Burke [:jrburke]]

This is for bug 906270, gaia-rtl bug, the latest spec for this calls for maintaining the LTR layout for the following:

* headers
* bottom toolbars

Also, for the bottom toolbar, there seemed to be a padding set that does not seem to match the current style of bottom toolbar layout, so seems like it should be removed.

I will have a pull request up shortly, it is mostly just removing some styles that assumed the order of the buttons would be reversed for RTL. With these changes, the email app gets a lot closer to the desired RTL end state.

Comment 1

[James Burke [:jrburke]]

Attachment: GitHub pull request

Some description in the pull request about the changes.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8520188 [details] [review]
GitHub pull request

Rubberstamp this assuming you have test it out already.

The last building block changes result regressions across all apps, like everywhere. I am not sure how safe is this change but we would just have to push it through all the way in v2.2.

Comment 3

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/757eef699e4517cbdcda8014c41a5d4a13cdfefa

from pull request:
https://github.com/mozilla-b2g/gaia/pull/26010

I appreciate the delicacy of changes in this area. Since these are RTL-scoped, I am hopeful they are a bit easier to get in at least at this point, when the RTL work is just starting. If the RTL spec changes things fundamentally, I can see that as not being very fun to fix though.

Comment 4

[Peter Bylenga [:PBylenga]]

Mass Edit: adding the [rtl-meta]