Persist typing notifications over link displays in status panel

RESOLVED FIXED in 1.6

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

({regression})

Dependency tree / graph

Details

Attachments

(1 attachment)

Assignee

Description

5 years ago
No description provided.
Assignee

Comment 1

5 years ago
Posted patch typing.diffSplinter Review
Attachment #8520198 - Flags: review?(florian)
Comment on attachment 8520198 [details] [diff] [review]
typing.diff

Review of attachment 8520198 [details] [diff] [review]:
-----------------------------------------------------------------

::: im/content/instantbird.js
@@ +133,5 @@
>    },
>  
>    updateStatusField: function () {
>      var text, type, types = ["overLink"];
> +    // if (this._busyUI)

Any reason this is still here? (Hmm...I seem to remember asking this once before! :-D)
Attachment #8520198 - Flags: review?(florian) → review-
Assignee

Comment 3

5 years ago
(In reply to Patrick Cloke [:clokep] from comment #2)
> Any reason this is still here? (Hmm...I seem to remember asking this once
> before! :-D)

It's baaaack! Now the change is actually needed though. I kept the commented out line to aid future ports of changes to this ported code.
Assignee

Updated

5 years ago
Attachment #8520198 - Flags: review- → review?(florian)
Assignee

Comment 4

5 years ago
(In reply to aleth [:aleth] from comment #3)
> (In reply to Patrick Cloke [:clokep] from comment #2)
> > Any reason this is still here? (Hmm...I seem to remember asking this once
> > before! :-D)

To be clear, the alternative is setting the _busyUI flag, but that may end up having unexpected side-effects, if not now then in the future.
Assignee

Updated

5 years ago
Blocks: 1105871
Assignee

Updated

5 years ago
Attachment #8520198 - Flags: review?(florian) → review?(nhnt11)
Comment on attachment 8520198 [details] [diff] [review]
typing.diff

Review of attachment 8520198 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I suppose you'll want to change the commit message to r=nhnt11 :)
Attachment #8520198 - Flags: review?(nhnt11) → review+
Assignee

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.