1096590 - Persist typing notifications over link displays in status panel

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Comment 1

[aleth [:aleth]]

Attachment: typing.diff

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8520198 [details] [diff] [review]
typing.diff

Review of attachment 8520198 [details] [diff] [review]:
-----------------------------------------------------------------

::: im/content/instantbird.js
@@ +133,5 @@
>    },
>  
>    updateStatusField: function () {
>      var text, type, types = ["overLink"];
> +    // if (this._busyUI)

Any reason this is still here? (Hmm...I seem to remember asking this once before! :-D)

Comment 3

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #2)
> Any reason this is still here? (Hmm...I seem to remember asking this once
> before! :-D)

It's baaaack! Now the change is actually needed though. I kept the commented out line to aid future ports of changes to this ported code.

Comment 4

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #3)
> (In reply to Patrick Cloke [:clokep] from comment #2)
> > Any reason this is still here? (Hmm...I seem to remember asking this once
> > before! :-D)

To be clear, the alternative is setting the _busyUI flag, but that may end up having unexpected side-effects, if not now then in the future.

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8520198 [details] [diff] [review]
typing.diff

Review of attachment 8520198 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I suppose you'll want to change the commit message to r=nhnt11 :)

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/0735d48d5fb3