Closed Bug 1096727 Opened 9 years ago Closed 9 years ago

(ios) Create account/provider APIs for login

Categories

(Firefox for iOS :: Firefox Accounts, defect)

Product:
Firefox for iOS
Component:
Firefox Accounts
Platform:
All
iOS 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

Create account/provider APIs for login
45 bytes, text/x-github-pull-request
wesj
: review+
Details | Review 
We need an account/provider contexts that can be handed off to the view controllers, along with AccountManager integration. This will allow us to use real FxA accounts for the login screen.
* Creates a simple Account API containing the Bookmarks provider
* Refactors AccountManager to use Accounts
* LoginViewController uses this API, so we now support real logins

One problem is that you can't actually log out/switch accounts without restarting the app; this is an issue documented in https://developer.apple.com/library/ios/qa/qa1727/_index.html. We'll have to figure out a reasonable workaround.
Attachment #8520341 - Flags: review?(wjohnston)
Depends on: 1096732
Comment on attachment 8520341 [details] [review]
Create account/provider APIs for login

I put some questions in the PR. Happy to + this if they're answered.
Attachment #8520341 - Flags: review?(wjohnston) → review-
Depends on: 1097400
Comment on attachment 8520341 [details] [review]
Create account/provider APIs for login

Need to rebase before merging.
Attachment #8520341 - Flags: review- → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
No longer depends on: 1097400
Group: mozilla-employee-confidential
Component: General → Firefox Accounts
Product: Firefox for Android → Firefox for iOS
You need to log in before you can comment on or make changes to this bug.