1096920 - Add test to delete entire call log when it has several calls, All tab

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Robert Chira [:RobertC]]

https://moztrap.mozilla.org/manage/case/2267/

Dialer-Call Log Edit Mode: As a user I can delete the entire call log.

Prerequisites:
a. Have several calls made to the test device.

    Launch the Dialer app and open the Call Log to the All tab.

    Tap on the Edit button in the top right corner of the screen.

    Verify that the call log is now in Edit mode where calls can be deleted.

    Tap the Select All button in the Call log.

    Verify that all the calls in the call log are selected with check marks.

    Tap the Delete button and confirm the action.

    Verify the operation is performed and no calls are left in the Call log.

Comment 1

[Robert Chira [:RobertC]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26291

Adhoc: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/342/console

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8525308 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26291

I didn't notice one thing in my last review: I think we can put the formatting of the date in the mock class. See comments in PR.

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8525308 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26291

Ok, waiting on an updated PR that addresses review comments from jlorenzo.

Comment 4

[Robert Chira [:RobertC]]

Comment on attachment 8525308 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26291

I updated the PR

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8525308 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26291

Looks good to me.

Comment 6

[Viorela Ioia [:viorela]]

Comment on attachment 8525308 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26291

Merged in: https://github.com/mozilla-b2g/gaia/commit/9ef69f29f5cd790d0a3a0fba0e89b6f4f765d5d4

Comment 7

[Martijn Wargers (dead)]

Robert, could you file a follow-up bug, about the time.sleep(1) workaround?
It should have been possible to write something like this:
self.marionette.execute_async_script('window.wrappedJSObject.CallLogDBManager.add(%s, function() {marionetteScriptFinished()});' % (json.dumps(call)))
..inside def insert_call_entry, so you would not have to use the time.sleep(1) function below.

We should figure out why it doesn't work, ideally.

Comment 8

[Robert Chira [:RobertC]]

I created Bug 1105168 for this.