Closed Bug 1105168 Opened 10 years ago Closed 6 years ago

Update insert_call_entry method to remove time.sleep()

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: RobertC, Unassigned)

Details

We should remove the time.sleep() from [1] and do something like the suggestion in [2]. I tried doing that when I first made the PR, but the async_script would timeout. I also moved the method in the atoms and tried listening for an onsuccess() event, but that did not work either.

This requires further investigation.


[1] https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#L378
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1096920#c7
QA Whiteboard: [fxosqa-auto-backlog+]
The suggestion in https://bugzilla.mozilla.org/show_bug.cgi?id=1096920#c7 is:
"
Robert, could you file a follow-up bug, about the time.sleep(1) workaround?
It should have been possible to write something like this:
self.marionette.execute_async_script('window.wrappedJSObject.CallLogDBManager.add(%s, function() {marionetteScriptFinished()});' % (json.dumps(call)))
..inside def insert_call_entry, so you would not have to use the time.sleep(1) function below.

We should figure out why it doesn't work, ideally.
"
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.