1097117 - [email] Accept share activities with type application/*

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[David Flanagan [:djf]]

When the gallery app wants to share images and videos in the same batch, it will use the type 'application/*', and the email app should be able to handle that type. See the discussion here: https://bugzilla.mozilla.org/show_bug.cgi?id=1095081#c7

Comment 1

[David Flanagan [:djf]]

Want to take this, Andrew?

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

James, I've been still driving most of the discussion about this re: email, but especially since this is conceptually front-end, you should definitely weigh in (and maybe it's a hat you get to wear all the time :).  And maybe provide the patch to seal the deal! >;).  rs=asuth for adding application/* to our manifest for our share definitions.

Note that I signed off on us adding application/* to pick in bug 848400 for v2.2 trunk (https://github.com/mozilla-b2g/gaia/pull/24688/files#diff-1436ccf67f86cb582d2d30bffec9cd0cL1059), so this would really just make us consistent.  (I now see you weren't on cc, so when that bug moved out of email you might have missed that nuance.  I had thought you were on cc at the time; sorry!)

Comment 3

[James Burke [:jrburke]]

Attachment: GitHub pull request

Carrying rs=asuth with this patch to just "application/*" to the share manifest section. Once try build is happy, I will merge.

Comment 4

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/41e4efdf00262d54a653fda21eac30f5554ac137

from  pull request:
https://github.com/mozilla-b2g/gaia/pull/26128