Closed Bug 1097117 Opened 8 years ago Closed 8 years ago

[email] Accept share activities with type application/*

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

defect
Not set
normal

Tracking

(feature-b2g:2.2?)

RESOLVED FIXED
2.1 S9 (21Nov)
feature-b2g 2.2?

People

(Reporter: djf, Assigned: jrburke)

References

Details

(Keywords: feature)

Attachments

(1 file)

46 bytes, text/x-github-pull-request
Details | Review
When the gallery app wants to share images and videos in the same batch, it will use the type 'application/*', and the email app should be able to handle that type. See the discussion here: https://bugzilla.mozilla.org/show_bug.cgi?id=1095081#c7
Want to take this, Andrew?
Flags: needinfo?(bugmail)
James, I've been still driving most of the discussion about this re: email, but especially since this is conceptually front-end, you should definitely weigh in (and maybe it's a hat you get to wear all the time :).  And maybe provide the patch to seal the deal! >;).  rs=asuth for adding application/* to our manifest for our share definitions.

Note that I signed off on us adding application/* to pick in bug 848400 for v2.2 trunk (https://github.com/mozilla-b2g/gaia/pull/24688/files#diff-1436ccf67f86cb582d2d30bffec9cd0cL1059), so this would really just make us consistent.  (I now see you weren't on cc, so when that bug moved out of email you might have missed that nuance.  I had thought you were on cc at the time; sorry!)
Flags: needinfo?(bugmail) → needinfo?(jrburke)
See Also: → 848400
feature-b2g: --- → 2.2?
Keywords: feature
Attached file GitHub pull request
Carrying rs=asuth with this patch to just "application/*" to the share manifest section. Once try build is happy, I will merge.
Assignee: nobody → jrburke
Status: NEW → ASSIGNED
Flags: needinfo?(jrburke)
Target Milestone: --- → 2.1 S9 (21Nov)
Merged in master:
https://github.com/mozilla-b2g/gaia/commit/41e4efdf00262d54a653fda21eac30f5554ac137

from  pull request:
https://github.com/mozilla-b2g/gaia/pull/26128
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.