1097138 - startup crash in appleffdav.dll

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Robert Kaiser]

This bug was filed from the Socorro interface and is 
report bp-f11b8bb1-80fd-405d-9153-c4a762141111.
=============================================================

The user comment on this report is "iCloud Bookmarks".

Those crashes make up ~7% of all crashes in 35.0a2 builds from the last 3 days, but we are seeing them in other versions as well.

Find more crashes at https://crash-stats.mozilla.com/report/list?signature=appleffdav.dll%400x1e865 https://crash-stats.mozilla.com/report/list?signature=appleffdav.dll%400x44c8 https://crash-stats.mozilla.com/report/list?signature=appleffdav.dll%400xa107

Comment 1

[Robert Kaiser]

David, do you know if there's anything we can do here?

Comment 2

[(Away)]

I'll try to install this:
Roaming\Mozilla\Firefox\Profiles\buvq47zd.dev-edition-default\extensions\[e-mail]\components\AppleFFDAV.dll
    Image name: AppleFFDAV.dll
    Timestamp:        Sat Nov 16 08:39:10 2013 (5286785E)

Comment 3

[(Away)]

I've been unable to repro the startup crash, but the reviews are quite mixed. It seems many people consistently hit this crash, while others have no problems.
https://addons.mozilla.org/en-US/firefox/addon/icloud-bookmarks/reviews/

Can we do something about this from the addons side?

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

I notified the developers through AMO. There's also a new version of the add-on that was just published (1.4.14), so maybe the problem is fixed there.

Comment 5

[(Away)]

The release notes say 1.4.14 was October 27. Crash-stats has seen this signature from both 1.2.12.0 and 1.4.14.0.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Not a high volume crash on 35 at this stage, untracking.

Comment 7

[John Hesling [:John99] (NeedInfo me)]

Also bp-a5b095e5-8002-44b0-a56c-0ece62150525  
Firefox 38.0.1 Crash Report [@ appleffdav.dll@0x1e7b5 ]
(I do not have bug edit privileges)
Module AppleFFDAV.dll 	1.4.14.0 	85437B1AA24548928FCAF0EE57ED8F941 	AppleFFDAV.pdb
As reported Sumo https://support.mozilla.org/en-US/questions/1063944

Comment 8

[(Away)]

These appleffdav.dll signatures perennially appear on our top crash reports. The update mentioned in comment 4 did not fix the crashes, and there have been no further updates in almost a year. The addon reviews frequently mention crashes: https://addons.mozilla.org/en-US/firefox/addon/icloud-bookmarks/reviews/

Is this enough reason for us to block the extension on stability grounds?

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

I sent a new message to the developers. If we don't get a response in a week or so, we can start looking into blocking it.

Comment 10

[Wesley Branton]

The iCloud Bookmarks addon was responsible for this users' crash.
SUMO Link: https://support.mozilla.org/en-US/questions/1098009

Perhaps we should consider blocking the addon.

Comment 11

[[:philipp]]

hi jorge, since apparently there was no follow-up or update from apple and this is still causing hundreds of startup crashes per week, can we proceed with soft-blocking the addon?

in addition there are also quite a few comments at https://addons.mozilla.org/en-US/firefox/addon/icloud-bookmarks/reviews that would suggest that the addon is no longer working in current versions of firefox (some say due to 64bit though).

Comment 12

[Jorge Villalobos [:jorgev] (he/him)]

Actually, the Apple dev has been responsive, and wanted us to direct affected users to their support site so they can try to debug the problem. I added the crashdebug team to the discussion (a month ago) but I haven't seen any progress on that.

I'll bring this up in the next release drivers meeting, because we need to assess how critical is this, and whether it's worth blocking even when the developer has been trying to address the problem.

Comment 13

[Mats Palmgren (inactive)]

I think it's long overdue to block this add-on.  Crashes like this is a reason for users
to switch browser.

Comment 14

[Jorge Villalobos [:jorgev] (he/him)]

A new version of the add-on was released on April 29th. The new version uptake will take a couple more days, and we should check if the crash stats change at all. ni Kairo for this.

Comment 15

[Robert Kaiser]

Sorry, I'm not working on this any more, I'm asking Philipp to take a look as he was already involved in this bug at some point.

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Jorge, this crash has jumped up 84 spots and is at #16 top rank now. I think we might need to consider blocking this add-on if it continues to spike. What do you think?

Comment 17

[Jorge Villalobos [:jorgev] (he/him)]

Yes. Can you check if version 1.4.22 is also crashing?

Comment 18

[[:philipp]]

this issue showing up in correlation files most of the time, since it's spread among various different signatures most of the time, but a manual spot-check on a couple of recent crashes show that this is still continuing with the newest 1.4.22 (maybe it's still a bit too early to judge if the over-all volume was changed for good or worse by the addon update).

Comment 19

[[:philipp]]

oops, comment 18 should read "this issue ISN'T showing up ..."

Comment 20

[[:philipp]]

the crash volume of various appleffdav.dll signatures wasn't significantly changing last week after the 1.4.22 release of their addon compared to the weeks before that (it's around 400 crashes per week).

Comment 21

[u279076]

This still shows up with a bunch of different signatures:
https://crash-stats.mozilla.com/search/?product=Firefox&signature=%5Eappleffdav.dll&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature

In particular, appleffdav.dll@0x5f2b seems like a new signature starting with Firefox 45. I'm not sure if these are all the same.

Comment 22

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.