1097166 - [Status bar] The bug icon overlaps with rocket bar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: BugIconOverlapping.png

Description:
The bug icon on the status bar overlaps with the rocket bar.

Pre-requisite: The Developer menu is enabled.

Repro Steps:
1) Update a Flame device to BuildID: 20141111040202.
2) Go to Settings > Developer.
3) Under "Debugging via USB", select "ADB only" or "ADB and DevTools".
4) Observe the bug icon displayed on the status bar.
  
Actual:
The bug icon overlaps with the rocket bar.
  
Expected: 
No overlapping issue occurs.
  
Environmental Variables:
Device: Flame 2.2 Master (319mb, KK, Shallow Flash)
BuildID: 20141111040202
Gaia: 6af3a8a833eb8bb651e8b188cb3f3c3a43bb4184
Gecko: 76b85b90a8cb
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
  
Repro frequency: 100%
See attached: screenshot

Comment 1

[Yeojin Chung [:YeojinC]]

The bug icon is a new feature on Flame 2.2. It does not exist on Flame 2.1.

Device: Flame 2.1 (319mb, KK, Shallow Flash)
BuildID: 20141111001201
Gaia: 7154f9aa0a69af56c8bd89be0c98d9791449527b
Gecko: 452db1a0c9a0
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue seems minor so not nominating to block on this.

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Caused by bug 998328. Jan can you take a look?

Comment 4

[Jan Keromnes [:janx]]

That's probably because the bug is a new/different type of status icon, using the Gaia icon font instead of the PNG sprite.

Will look at it tomorrow, thanks Michael for letting me know.

Comment 5

[Gregor Wagner [:gwagner]]

Any update here?

Comment 6

[Jan Keromnes [:janx]]

Still haven't had time to look into it, so leaving needinfo.

Comment 7

[Jan Keromnes [:janx]]

Attachment: gaia pull request

It turns out that the debugging icon simply didn't respect the ".sb-hide-debugging" class. Michael, please have a look.

Comment 8

[Jan Keromnes [:janx]]

Thanks! Merged in https://github.com/mozilla-b2g/gaia/commit/a57ba36