Closed
Bug 1097283
Opened 11 years ago
Closed 11 years ago
Review NS_ABORT_OOM callsites for count/bytes mismatches
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: away, Assigned: away)
Details
Attachments
(1 file)
|
13.72 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
I just made this mistake myself by copying nearby code in bug 1096155. As atonement, I'm going to fix all of them!
Contains a drive-by fix in nsTextFragment.h: Presumably the append operation uses both lengths.
Open to other names for AllocFailed.
Attachment #8521070 -
Flags: review?(nfroyd)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8521070 [details] [diff] [review]
Pound of cure + ounce of prevention
Nice.
Attachment #8521070 -
Flags: review?(nfroyd) → review+
gcc didn't like it. https://hg.mozilla.org/integration/mozilla-inbound/rev/540b81dfaf97
Now with 37% more build trickery.
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cedc0acd40b
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=78a39c45d9f5
|
|
||
Comment 6•11 years ago
|
||
Assignee: nobody → dmajor
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•