1097305 - Verify conditional request handling for commonplace HTML files

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: General, defect, P3)

Description

[Mathieu Pillard [:mat]]

https://redbot.org/?uri=https%3A%2F%2Fmarketplace.firefox.com%2Fiframe-install.html%3Fb%3D9db7ff7-546261c0%26cache%3D31536000
https://redbot.org/?uri=https%3A%2F%2Fmarketplace.firefox.com

Note this:
* An If-None-Match conditional request returned the full content, but it had changed.

This sucks, the pages are cached but once their TTL expires the browser will have to download them fully again even when they haven't changed.

In the case of "/", Last-Modified is absent, but the ETag is not stable. I think this is because of my inclusion of fx_auth stuff in bug 1093584. Maybe we can tweak this.

In the case of "iframe-install.html", the ETag is stable, and we correctly return a 304 with If-None-Match, but Last-Modified is also present and it changes every request. Need to figure out why it's there and remove it.

Comment 1

[Mathieu Pillard [:mat]]

Weirdly, the ETag/Last-Modified for the feed API endpoint (and I assume others) is not stable either:

https://redbot.org/?uri=https%3A%2F%2Fmarketplace.firefox.com%2Fapi%2Fv2%2Ffeed%2Fget%2F%3Fcache%3D21600%26lang%3Den-US%26limit%3D10%26region%3Dus%26vary%3D0

The CDN seems to hide this problem because of the high max-age we are now setting, but that's still worth looking into.

Comment 2

[Mathieu Pillard [:mat]]

The ETag issue on "/" is a real problem, and New Relic can mess with things too, as it's enabled on only one webserver (so the content returned will be different for that webserver)

We do set a useless, always changing Last-Modified, because of django (https://github.com/django/django/blob/master/django/utils/cache.py#L126) but our ETags are stable and we answer If-None-Match correctly, so I'm ignoring this for now.