1097382 - OS sniffing should detect Windows 10 from "Windows NT 6.4" instead of detecting Windows NT

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[:Gijs (he/him)]

Pretty much as per summary.

Comment 1

[:glob ✱]

Attachment: 3.patch

migrated from https://github.com/mozilla/webtools-bmo-bugzilla/pull/3.patch

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8521407 [details] [diff] [review]
3.patch

Review of attachment 8521407 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Comment 3

[:glob ✱]

thanks gijs!

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   e15f335..ecc04a6  master -> master

Comment 4

[Frédéric Buclin]

Why hasn't this patch been pushed upstream?

Comment 5

[:Gijs (he/him)]

(In reply to Frédéric Buclin from comment #4)
> Why hasn't this patch been pushed upstream?

Because I have no idea how to? If you tell me what you need from me to push this upstream, I'd be happy to oblige. Keep in mind that it does seem like MS will change the UA bits and exposed version number once more before final release.

Comment 6

[David Lawrence [:dkl]]

(In reply to :Gijs Kruitbosch from comment #5)
> (In reply to Frédéric Buclin from comment #4)
> > Why hasn't this patch been pushed upstream?
> 
> Because I have no idea how to? If you tell me what you need from me to push
> this upstream, I'd be happy to oblige. Keep in mind that it does seem like
> MS will change the UA bits and exposed version number once more before final
> release.

File a similar bug to this one under the product Bugzilla with component "Creating Bugs". The fork the upstream Bugzilla git repo[1] and create a similar pull request and place the pull request link in the attachment form here using the URL feature. The ask for review? from one of the suggested reviewers.

Once it is r+ and then approved, the reviewer can move it over from github like we did here and commit it to the upstream code base.

There is a docker container for upstream Bugzilla[2] as well that you can use to test your patches before review.

Thanks
dkl

[1] https://github.com/bugzilla/bugzilla
[2] https://github.com/dklawren/docker-bugzilla