1097436 - [MSE] Enable MP4 support instead of WebM on Windows

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Enable MP4 support for MSE on Windows and disable WebM support. This will get more testing for MP4 playback on Windows.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Enable MSE support for MP4 on Windows and disable WebM

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=446b1b551185

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Enable MSE support for MP4 on Windows and disable WebM

Comment 4

[Karl Tomlinson (:karlt)]

Comment on attachment 8521972 [details] [diff] [review]
Enable MSE support for MP4 on Windows and disable WebM

I'm assuming you've tested that mp4 is working.

I'll look into getting mp4 CI testing running ASAP.

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe5ae33fc62d

Comment 6

[Chris Peterson [:cpeterson]]

This bug is necessary for basic playback of EME video on Windows.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fe5ae33fc62d

Comment 8

[Jet Villegas (inactive)]

Attachment: Capture.PNG

youtube.com/html5 isn't detecting MSE/H.264 (see attached)

Comment 9

[Matt Woodrow (:mattwoodrow)]

(In reply to Jet Villegas (:jet) from comment #8)
> Created attachment 8523120 [details]
> Capture.PNG
> 
> youtube.com/html5 isn't detecting MSE/H.264 (see attached)

What is the value of media.mediasource.mp4.enabled in your profile?

Comment 10

[Jet Villegas (inactive)]

(In reply to Matt Woodrow (:mattwoodrow) from comment #9)
> What is the value of media.mediasource.mp4.enabled in your profile?

true.

The JS on youtube.com looks like this:

checkMSECompatibility('video/mp4; codecs="avc1.4d404f"'));

Do we support that codec?

Comment 11

[Matt Woodrow (:mattwoodrow)]

From reading our parsing code, it looks like it's taking 4f (79) as the AVC level. 

I can't find anything about levels higher than 5.2 (52), so I guess that's why its failing. I don't know why youtube is using an AVC level that doesn't appear to exist though.

Comment 12

[Jet Villegas (inactive)]

It appears that Chromium will allow any codec that matches this pattern: "avc1.*"

https://code.google.com/p/chromium/codesearch#chromium/src/media/filters/stream_parser_factory.cc&rcl=1415851762&l=133

Comment 13

[Matt Woodrow (:mattwoodrow)]

That's interesting, they're not using that codec for actual videos (that I've seen so far), just for the feature test on youtube.com/html5.

We could do the same as chrome as report that we support all avc1.* codecs, hardcode this specific one, or contact youtube and ask them to test with a real codec.

What do you think Anthony?

Comment 14

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

I've already asked YouTube about this but didn't get an actionable answer. I will follow up on it.

Comment 15

[Masatoshi Kimura [:emk]]

Is this change permanent? (That is, do we give up spreading WebM completely?) If not, "hardcode this specific one" would be a sensible option until Google responds.

Comment 16

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

(In reply to Masatoshi Kimura [:emk] from comment #15)
> Is this change permanent? (That is, do we give up spreading WebM
> completely?)

No.

> If not, "hardcode this specific one" would be a sensible option
> until Google responds.

The youtube.com/html5 page is bogus but YouTube itself functions correctly.

Comment 17

[crschmidt]

The YouTube HTML5 page was fixed back in November. If this issue was about improper reporting on that page, it appears to now be fixed.

(On Mac, H.264 + MSE still is red/false; This is accurately reflecting the fact that the Cisco OpenH264 plugin doesn't support the extended profiles needed for MSE H.264 playback.)

Comment 18

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

MSE playback with MP4 should be available on Mac OSX in beta, aurora and nightly.

Comment 19

[Chris]

all 60fps youtube videos refuse to play and eventually fallback to another codec. Windows7 FF36.

Comment 20

[Emanuel Hoogeveen [:ehoogeveen]]

MSE support was turned off for Firefox 36 because there were still too many problems with it (the crash volume was too high). It should work in Firefox 37 and up.

Comment 21

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

(In reply to Emanuel Hoogeveen [:ehoogeveen] from comment #20)
> MSE support was turned off for Firefox 36 because there were still too many
> problems with it (the crash volume was too high). It should work in Firefox
> 37 and up.

Bug 1127925 and bug 1128170.