Closed
Bug 1097442
Opened 11 years ago
Closed 11 years ago
Rename EventTarget to EventListener
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S9 (21Nov)
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
(Whiteboard: [p=1])
Attachments
(2 files)
|
12.48 KB,
patch
|
dimi
:
review+
|
Details | Diff | Splinter Review |
|
5.67 KB,
patch
|
dimi
:
review+
|
Details | Diff | Splinter Review |
I used the term EventTarget in Bug 1069177, however I think the correct one should be EventListener.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8521114 -
Flags: review?(dlee)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8521115 -
Flags: review?(dlee)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8521114 [details] [diff] [review]
Part 1: rename eventTarget to eventListener
Review of attachment 8521114 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/nfc/nsINfcContentHelper.idl
@@ +104,2 @@
> *
> + * @param listener An instance of the nsINfcDOMEventListener.
It would be better follow the same coding style for the comment in this IDL
Attachment #8521114 -
Flags: review?(dlee) → review+
|
|
||
Updated•11 years ago
|
Attachment #8521115 -
Flags: review?(dlee) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/20bb1295dd4c
https://hg.mozilla.org/integration/b2g-inbound/rev/4f9c72685dce
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S9 (21Nov)
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/20bb1295dd4c
https://hg.mozilla.org/mozilla-central/rev/4f9c72685dce
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•