1097675 - [Ambient Indicator] Ambient indicator gets active (and never gets deactivated) on alarms

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Alberto Pastor [:albertopq]]

STR:

1.- Set an alarm on the clock app
2.- Wait for the alarm time

Expected:

The ambient indicator is not animated (unless clicking the home button)

Actual:

The ambient indicator gets animated, and don't disappear even after closing the alarm

Comment 1

[Alberto Pastor [:albertopq]]

I verified that this bug was happening before bug 1067913 landed, so is not a regression of that one. :alive, any idea?

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

No idea, but I guess it's due to event timing of AttentionWindowManager.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

On it

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: patch: ignore hidden window when updating indicator

The root cause if that we take the hidden callscreen window into account when updating the indicator.

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8527483 [details] [review]
patch: ignore hidden window when updating indicator

lgtm :) (nice external testing!)

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/6af28285cdaa0551782cecdb48bfc8a86c8257db \O/