1097834 - Show original sources option in Firefox Developer Edition not working properly.

Status: NEW

(DevTools :: Style Editor, defect, P3)

Description

[mattfregoe]

Using Firefox Developer Edition (35.0a2) the default Style Editor setting "Show original sources" is marked true by default, but does not function properly until unchecked and re-checked in the Toolbox Options.

I tested this by inspecting an element on a webpage which has its main CSS stylesheet compiled from a set of SASS files.

After unchecking and re-checking the option, the proper .scss file line numbers appeared next to the associated element styles.

Comment 1

[mattfregoe]

Upon further review, the above checking/unchecking did not resolve the issue. It appears there may be a different issue in the works.

In Firefox Developer Edition (35.0a2) I do not see line numbers when show original sources is marked true, I simply get 'null' after the colon and the original scss file does not show. For example my h1 style is marked as being on: 'style.css:null'.

In Firefox (33.1) I get a different result entirely when show original sources is marked as true. Sadly, it is also incorrect. I get a scss line number, but pointing to the last style on the last imported SASS file. For example the same h1 style as above is marked as being on: '_base.scss:526' but this is incorrect.

Comment 2

[mattfregoe]

It appears this might be an error with my source maps, I'm using grunt-sass to complie them and it appears node-sass and libsass have open issues about a source map problem.

Still, the differences between Firefox Stable and Developer Edition output may be worth looking into.

Comment 3

[mattfregoe]

After tweaking some settings with my SASS compiler, I was able to get the correct line numbers in Stable Firefox (33.1.1) but the line numbers still appeared wrong in Firefox Developer Edition (35.0a2 (2014-11-18)) 

I attached screenshots from each browser inspecting the an element to show the differences.

Comment 4

[mattfregoe]

Attachment: Inspecting an H1 element in Firefox (33.1.1)

Comment 5

[mattfregoe]

Attachment: Inspecting the same H1 element in Firefox Developer Edition (35.0a2 (2014-11-18)

Comment 6

[Heather Arthur [:harth]]

I was able to reproduce this and bisected:

Last good revision: 0ed32d9a42d6 (2014-10-06)
First bad revision: 9ee9e193fc48 (2014-10-07)

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0ed32d9a42d6&tochange=9ee9e193fc48

Two candidates I see:
bug 1077376
bug 1076887

Leaning towards bug 1076887

Comment 7

[Heather Arthur [:harth]]

Attachment: Testcase

This is a testcase that fails for me. Reproduce by opening index.html from a file url, then inspecting the link element that says "Inspect this element". Turn on the "Show original sources" option if it's not already on.

Comment 8

[Heather Arthur [:harth]]

Confirmed from bisecting that it's bug 1076887 that regressed this.

Comment 9

[Patrick Brosset <:pbro>]

Triaging. This has been a P1 for more than a year with no significant activity. Returning to the backlog. (Filter on CLIMBING SHOES).

Comment 10

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).

Comment 11

[Ian Tommins ('thelem')]

I can reproduce this. When I check "show original sources" and return to the inspector tab I will see the rules for the selected element with their less sources, but when I then click on a different element I lose all css/less rules.