1097874 - the message logged when assert.throws fails is confusing when a regular expression is used

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

At the moment a failing assert.throw() which uses a reg exp looks like:

console.error: addon-sdk: 
  fail:
  Setting a pref to [] should raise error - { // /can't set pref test_set_pref to value ''; it isn't a string, integer, or boolean/

    "__proto__": { // /(?:)/

    }
} throws "can't set pref test_set_pref to value ''; it isn't a String, Number, or Boolean"

It should look like:

console.error: addon-sdk: 
  fail:
  Setting a pref to [] should raise error - "/can't set pref test_set_pref to value ''; it isn't a string, integer, or boolean/" does not match message "can't set pref test_set_pref to value ''; it isn't a String, Number, or Boolean"

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Note: discovered when working on bug 1092882

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1709

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/fd3ebd4854de5cf56143358e2bd116caf47b86dc
Bug 1097874 assert.throws expected value is messy when a reg exp is used

https://github.com/mozilla/addon-sdk/commit/786929089f8b7f3548f75c5e0f4ac17ace3a7d6b
Merge pull request #1709 from erikvold/1097874

Bug 1097874 assert.throws expected value is messy when a reg exp is used r=@jsantell