Closed
Bug 1097931
Opened 8 years ago
Closed 8 years ago
Don't clip to padding in top sites grid
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Firefox for Android Graveyard
Awesomescreen
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(1 file, 1 obsolete file)
3.09 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
Otherwise the list/grid scrolls into 'nowhere', before the actual top edge of the panel.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8521633 [details] [diff] [review] Don't clip top sites list to padding (r=margaret) We should probably do the same in the search activity btw.
Attachment #8521633 -
Flags: review?(margaret.leibovic)
Assignee | ||
Updated•8 years ago
|
Attachment #8521632 -
Attachment is obsolete: true
Comment 4•8 years ago
|
||
Comment on attachment 8521633 [details] [diff] [review] Don't clip top sites list to padding (r=margaret) Review of attachment 8521633 [details] [diff] [review]: ----------------------------------------------------------------- I'm not sure if you still meant for mcomella to review this, but this sounds fine to me. Can you file a separate bug for the search activity?
Attachment #8521633 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to :Margaret Leibovic from comment #4) > Comment on attachment 8521633 [details] [diff] [review] > Don't clip top sites list to padding (r=margaret) > > Review of attachment 8521633 [details] [diff] [review]: > ----------------------------------------------------------------- > > I'm not sure if you still meant for mcomella to review this, but this sounds > fine to me. Can you file a separate bug for the search activity? Nope, I actually meant you :-) Filed bug 1099047.
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/708b312b230f
Comment 7•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/708b312b230f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•