1097931 - Don't clip to padding in top sites grid

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Lucas Rocha (:lucasr)]

Otherwise the list/grid scrolls into 'nowhere', before the actual top edge of the panel.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Don't clip top sites list to padding (r=mcomella)

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Don't clip top sites list to padding (r=margaret)

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8521633 [details] [diff] [review]
Don't clip top sites list to padding (r=margaret)

We should probably do the same in the search activity btw.

Comment 4

[:Margaret Leibovic]

Comment on attachment 8521633 [details] [diff] [review]
Don't clip top sites list to padding (r=margaret)

Review of attachment 8521633 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure if you still meant for mcomella to review this, but this sounds fine to me. Can you file a separate bug for the search activity?

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to :Margaret Leibovic from comment #4)
> Comment on attachment 8521633 [details] [diff] [review]
> Don't clip top sites list to padding (r=margaret)
> 
> Review of attachment 8521633 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm not sure if you still meant for mcomella to review this, but this sounds
> fine to me. Can you file a separate bug for the search activity?

Nope, I actually meant you :-) Filed bug 1099047.

Comment 6

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/708b312b230f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/708b312b230f