Closed Bug 1097931 Opened 5 years ago Closed 5 years ago

Don't clip to padding in top sites grid

Categories

(Firefox for Android :: Awesomescreen, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 36

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(1 file, 1 obsolete file)

Otherwise the list/grid scrolls into 'nowhere', before the actual top edge of the panel.
Comment on attachment 8521633 [details] [diff] [review]
Don't clip top sites list to padding (r=margaret)

We should probably do the same in the search activity btw.
Attachment #8521633 - Flags: review?(margaret.leibovic)
Attachment #8521632 - Attachment is obsolete: true
Comment on attachment 8521633 [details] [diff] [review]
Don't clip top sites list to padding (r=margaret)

Review of attachment 8521633 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure if you still meant for mcomella to review this, but this sounds fine to me. Can you file a separate bug for the search activity?
Attachment #8521633 - Flags: review?(margaret.leibovic) → review+
(In reply to :Margaret Leibovic from comment #4)
> Comment on attachment 8521633 [details] [diff] [review]
> Don't clip top sites list to padding (r=margaret)
> 
> Review of attachment 8521633 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm not sure if you still meant for mcomella to review this, but this sounds
> fine to me. Can you file a separate bug for the search activity?

Nope, I actually meant you :-) Filed bug 1099047.
https://hg.mozilla.org/mozilla-central/rev/708b312b230f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
You need to log in before you can comment on or make changes to this bug.