1099047 - Don't clip to padding in search activity

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Lucas Rocha (:lucasr)]

Otherwise the list scrolls into 'nowhere', before the divider below the search entry.

Comment 1

[:Margaret Leibovic]

I'm actually a bit confused about what we're trying to achieve in this bug... Are you talking about the search history list, the search suggestions, or both? And are you saying there should be no space between the search bar underline and the list below? I don't think that adding clipToPadding="false" on the ListViews will achieve this effect, since the search bar has its own padding, so the underline is not actually the bottom of that view.

Comment 2

[Lucas Rocha (:lucasr)]

(In reply to :Margaret Leibovic from comment #1)
> I'm actually a bit confused about what we're trying to achieve in this
> bug... Are you talking about the search history list, the search
> suggestions, or both? And are you saying there should be no space between
> the search bar underline and the list below? I don't think that adding
> clipToPadding="false" on the ListViews will achieve this effect, since the
> search bar has its own padding, so the underline is not actually the bottom
> of that view.

Here's what I'm talking about: https://plus.google.com/+AndroidDevelopers/posts/LpAA7q4jw9M

In other words: it's fine to have a padding on top of the list but let's make the top padding scroll with the content. That applies to both search history list and search suggestions. Maybe the webview will still need the top padding to visually separate it from the divider line below the text entry.

Comment 3

[Jan Henning [:JanH]]

This is an ex-Search Activity now (bug 1221344).