Don't clip to padding in search activity

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
4 years ago
7 months ago

People

(Reporter: lucasr, Unassigned)

Tracking

Details

(Reporter)

Description

4 years ago
Otherwise the list scrolls into 'nowhere', before the divider below the search entry.
(Reporter)

Updated

4 years ago
Summary: on't clip to padding in search activity → Don't clip to padding in search activity

Updated

4 years ago
Blocks: 1017135

Comment 1

4 years ago
I'm actually a bit confused about what we're trying to achieve in this bug... Are you talking about the search history list, the search suggestions, or both? And are you saying there should be no space between the search bar underline and the list below? I don't think that adding clipToPadding="false" on the ListViews will achieve this effect, since the search bar has its own padding, so the underline is not actually the bottom of that view.
Flags: needinfo?(lucasr.at.mozilla)
(Reporter)

Comment 2

4 years ago
(In reply to :Margaret Leibovic from comment #1)
> I'm actually a bit confused about what we're trying to achieve in this
> bug... Are you talking about the search history list, the search
> suggestions, or both? And are you saying there should be no space between
> the search bar underline and the list below? I don't think that adding
> clipToPadding="false" on the ListViews will achieve this effect, since the
> search bar has its own padding, so the underline is not actually the bottom
> of that view.

Here's what I'm talking about: https://plus.google.com/+AndroidDevelopers/posts/LpAA7q4jw9M

In other words: it's fine to have a padding on top of the list but let's make the top padding scroll with the content. That applies to both search history list and search suggestions. Maybe the webview will still need the top padding to visually separate it from the divider line below the text entry.
Flags: needinfo?(lucasr.at.mozilla)

Comment 3

10 months ago
This is an ex-Search Activity now (bug 1221344).
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → WONTFIX

Updated

7 months ago
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.