Closed Bug 1099047 Opened 6 years ago Closed 3 years ago

Don't clip to padding in search activity

Categories

(Firefox for Android Graveyard :: Search Activity, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: lucasr, Unassigned)

References

Details

Otherwise the list scrolls into 'nowhere', before the divider below the search entry.
Summary: on't clip to padding in search activity → Don't clip to padding in search activity
Blocks: search
I'm actually a bit confused about what we're trying to achieve in this bug... Are you talking about the search history list, the search suggestions, or both? And are you saying there should be no space between the search bar underline and the list below? I don't think that adding clipToPadding="false" on the ListViews will achieve this effect, since the search bar has its own padding, so the underline is not actually the bottom of that view.
Flags: needinfo?(lucasr.at.mozilla)
(In reply to :Margaret Leibovic from comment #1)
> I'm actually a bit confused about what we're trying to achieve in this
> bug... Are you talking about the search history list, the search
> suggestions, or both? And are you saying there should be no space between
> the search bar underline and the list below? I don't think that adding
> clipToPadding="false" on the ListViews will achieve this effect, since the
> search bar has its own padding, so the underline is not actually the bottom
> of that view.

Here's what I'm talking about: https://plus.google.com/+AndroidDevelopers/posts/LpAA7q4jw9M

In other words: it's fine to have a padding on top of the list but let's make the top padding scroll with the content. That applies to both search history list and search suggestions. Maybe the webview will still need the top padding to visually separate it from the divider line below the text entry.
Flags: needinfo?(lucasr.at.mozilla)
This is an ex-Search Activity now (bug 1221344).
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.