Closed
Bug 1098000
Opened 10 years ago
Closed 10 years ago
Failing MOZ_ASSERT(mGLTextureSource == aTextureSource);
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: khuey, Assigned: nical)
References
Details
(Keywords: assertion, regression)
Attachments
(2 files, 2 obsolete files)
6.53 KB,
text/plain
|
Details | |
7.29 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
I see this pretty reliably when repeatedly opening and closing a "tray" of icons on the homescreen.
Comment 1•10 years ago
|
||
khuey, can you explain more about '"tray" of icons'? Is it "Smart Collection"? or other things? I try to reproduce the problem around homescreen app. But I could not reproduce it.
Flags: needinfo?(khuey)
Reporter | ||
Comment 2•10 years ago
|
||
If you have the latest Gaia master the dividers between icon groups have been replaced with some sort of "tray", and there's an arrow to collapse it at the top left.
Flags: needinfo?(khuey)
Comment 3•10 years ago
|
||
Thanks for the info! I confirmed that the problem happens on master flame.
Updated•10 years ago
|
Assignee: nobody → sotaro.ikeda.g
Comment 4•10 years ago
|
||
I confirmed that the assertion failure happened when GrallocTextureHostOGL is used from multiple ImageHosts.
Comment 5•10 years ago
|
||
How to call GrallocTextureHostOGL::UnbindTextureSource() has a problem. UnbindTextureSource() should be called when all CompositableClients end up to use it. But it is called when one CompositableHost stop to use it. This is a regression of Bug 1077301.
Updated•10 years ago
|
Blocks: 1077301
Keywords: regression
Comment 6•10 years ago
|
||
Comment 8•10 years ago
|
||
The problem was fixed. But genlock failure happened on hamachi.
Assignee | ||
Comment 9•10 years ago
|
||
You are right Sotaro, UnbindTextureSource should not be called if the TextureHost is used with another compositable. I think that this patch is correct but I need to test it (so just tagging for feedback until I've confirmed that it works).
Attachment #8522837 -
Flags: feedback?(sotaro.ikeda.g)
Assignee | ||
Comment 10•10 years ago
|
||
I just tested on hamachi and I get no genlock failure with this patch
Assignee | ||
Updated•10 years ago
|
Attachment #8522837 -
Flags: feedback?(sotaro.ikeda.g) → review?(sotaro.ikeda.g)
Comment 11•10 years ago
|
||
Comment on attachment 8522837 [details] [diff] [review] track the number of compositable references in texture host too Thanks! Much better than mine and confirmed no genlock failure on hamachi.
Attachment #8522837 -
Flags: review?(sotaro.ikeda.g) → review+
Updated•10 years ago
|
Attachment #8522545 -
Attachment is obsolete: true
Comment 12•10 years ago
|
||
nical, I assigned you to this bug, since you created the patch.
Assignee: sotaro.ikeda.g → nical.bugzilla
Assignee | ||
Comment 13•10 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #11) > Thanks! Much better than mine and confirmed no genlock failure on hamachi. You did the hard part which was to diagnose the problem. landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/085e5a323eed
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/085e5a323eed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•