Closed Bug 1098118 Opened 5 years ago Closed 5 years ago

Pass correct number of arguments to browser API

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kanru, Assigned: kanru)

References

Details

Attachments

(3 files)

Attached patch gaia.patchSplinter Review
1. Don't bind this arg to null
2. Arguments aren't optional
Attachment #8521970 - Flags: feedback?(alive)
Attachment #8521970 - Flags: feedback?(alive) → feedback+
Attachment #8521982 - Flags: review?(alive)
Attachment #8521982 - Flags: review?(alive)
Attachment #8521982 - Flags: review?(alive) → review+
Needs to checkin the CLOSED gaia tree in order to fix the Gij failure.
Keywords: checkin-needed
Thank you for the patch. In master: https://github.com/mozilla-b2g/gaia/commit/9593da7955c13baa7224de9448c05df5e815d268
Assignee: nobody → kchen
Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Looks like we missed the call to |sendTouchEvent| in utility_tray.js, so launching the rocketbar from the top left corner is still broken on central/master.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Alive or Etienne, please review this.
Attachment #8523344 - Flags: review?(etienne)
Attachment #8523344 - Flags: review?(alive)
Attachment #8523344 - Flags: review?(etienne)
Attachment #8523344 - Flags: review?(alive)
Attachment #8523344 - Flags: review+
Keywords: checkin-needed
(In reply to Etienne Segonzac (:etienne) from comment #4)
> Looks like we missed the call to |sendTouchEvent| in utility_tray.js, so
> launching the rocketbar from the top left corner is still broken on
> central/master.

Looks like we should move any browser API access into browserMixin to prevent this issue in the future :)
Reverted for causing frequent failures like the log shown below. Also, don't forget to resolve bugs when landing on Gaia in the future.
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=853783&repo=b2g-inbound

Master: https://github.com/mozilla-b2g/gaia/commit/c39d1bf4317f7d8b3582deff5b284fb708b17e73
Hey Zac, any idea on why the last patch failed?

(it fixes a JS ERROR, so not sure how it could cause a python test to fail unless we were out of sync with the gecko change...)
Flags: needinfo?(zcampbell)
Let's fix the sendTouchEvent call in bug 1099137, since that one has tests along with the patch.

Leaving ni? on Zac in case he has any ideas about why this small change would cause python failures.
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
(In reply to Etienne Segonzac (:etienne) from comment #9)
> Hey Zac, any idea on why the last patch failed?
> 
> (it fixes a JS ERROR, so not sure how it could cause a python test to fail
> unless we were out of sync with the gecko change...)

Etienne, the screenshot ( http://mozilla-releng-blobs.s3.amazonaws.com/blobs/b2g-inbound/sha512/cb85b5ca1489e4b90006b4323462592dac715e84c925a51037f528e2b8038e438efd65ce11a6af9f8d28371dcc38546bd7972545793d83a31dd532d056c7e2da )  tells a lot -  the test is expecting the utility tray to be open but it is not.

Also the assertion failure reflects the utility tray and notification. the u'' in the assertion failure means that the element [notification] is present but there is no visible text.

At a hunch, I expect the Marionette flick action in this method is the source of the intermittent, it's perhaps not long enough (either pixels, or duration), or just failing outright:
https://github.com/mozilla-b2g/gaia/blob/ecab09637388095548c4cd2533e25ff51921cd76/tests/python/gaia-ui-tests/gaiatest/apps/system/app.py#L45
Flags: needinfo?(zcampbell)
Blocks: 1101227
You need to log in before you can comment on or make changes to this bug.