Closed Bug 1098193 Opened 5 years ago Closed 5 years ago

[Telephony] The state of incoming call should be WAITING if there are existing calls

Categories

(Firefox OS Graveyard :: Emulator, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S9 (21Nov)

People

(Reporter: aknow, Assigned: aknow)

References

Details

Attachments

(4 files, 3 obsolete files)

Originally, the call state is always set to INCOMING. This is not correct. We should consider whether there are existing calls or not, and then set the state to WAITING or INCOMING accordingly.
Edgar,

May I have your review? Thank you.
Attachment #8522086 - Flags: review?(echen)
Comment on attachment 8522086 [details] [review]
Phase 2 - [platform_external_qemu] PR 119

Leave some comments on github. Thank you.
Attachment #8522086 - Flags: review?(echen)
Comment on attachment 8522086 [details] [review]
Phase 2 - [platform_external_qemu] PR 119

r=me, please help to provide a try result includes this qemu changes by updating `b2g/config/emualtor/sources.xml` (like https://hg.mozilla.org/try/rev/8d99fb03ee71) before requesting checkin-needed. Thank you.
Attachment #8522086 - Flags: review+
Blocks: 1093014
Attached patch Fix tests: using waiting state (obsolete) — Splinter Review
We have 'waiting' state now. Need to modeify some test cases.
Attachment #8522741 - Flags: review?(htsai)
Attachment #8522086 - Attachment description: PR 119 → Phase 2: PR 119
We have to disable affected tests for the emulator changes.
Attachment #8522747 - Flags: review?(htsai)
Attachment #8522741 - Attachment is obsolete: true
Attachment #8522741 - Flags: review?(htsai)
Attachment #8522749 - Flags: review?(htsai)
Attachment #8522747 - Attachment description: Phase 1: Part 1: Disable test cases due to emulator changes → Phase 1 - Part 1: Disable test cases due to emulator changes
Attachment #8522086 - Attachment description: Phase 2: PR 119 → Phase 2 - PR 119
Blocks: 1100200
Comment on attachment 8522747 [details] [diff] [review]
Phase 1 - Part 1: Disable test cases due to emulator changes

Review of attachment 8522747 [details] [diff] [review]:
-----------------------------------------------------------------

Not really get the idea - why are all deleted items going to be added back in Phase3 patch?
Comment on attachment 8522749 [details] [diff] [review]
Phase 3 - Part 2: Fix tests: using waiting state

Review of attachment 8522749 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good except the confusing part of manifest.ini @@?
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #7)
> Comment on attachment 8522747 [details] [diff] [review]
> Phase 1 - Part 1: Disable test cases due to emulator changes
> 
> Review of attachment 8522747 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Not really get the idea - why are all deleted items going to be added back
> in Phase3 patch?

Never mind, I got it... This is for you to be able to land emulator part safely. :)
Comment on attachment 8522747 [details] [diff] [review]
Phase 1 - Part 1: Disable test cases due to emulator changes

Review of attachment 8522747 [details] [diff] [review]:
-----------------------------------------------------------------

For the sake of landing Part2 safely!
Attachment #8522747 - Flags: review?(htsai) → review+
Attachment #8522749 - Flags: review?(htsai) → review+
Attachment #8522086 - Attachment description: Phase 2 - PR 119 → Phase 2 - [platform_external_qemu] PR 119
In order to land the patch smoothly, we have to separate it into 3 phases.
- phase1: disable the affected test cases
- phase2: merge emulator PR
- phase3: when change of phase 2 is available on try, re-enbale the test cases and fix them

For phase1 + phase2 (manually update the emulater path)
Try looks good
https://tbpl.mozilla.org/?tree=Try&rev=206c802119f3

Phase 1
https://hg.mozilla.org/integration/b2g-inbound/rev/0df3fe71a38d

Set checkin-needed for only => Phase 2 - [platform_external_qemu] PR 119
Thank you.
Attachment #8526564 - Attachment description: [final] Part 1: Disable test cases due to emulator changes. r=hsinyi → Phase 1 - [final] Part 1: Disable test cases due to emulator changes. r=hsinyi
Hi,

the patch failed to apply cleanly:

patching file dom/telephony/test/marionette/manifest.ini
Hunk #1 FAILED at 13
Hunk #2 FAILED at 44
2 out of 2 hunks FAILED -- saving rejects to file dom/telephony/test/marionette/manifest.ini.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 0001-Disable-test-cases-due-to-emulator-changes.-r-hsinyi.patch

could you take a look, thanks!
Flags: needinfo?(szchen)
Keywords: checkin-needed
(In reply to Carsten Book [:Tomcat] from comment #14)
> Hi,
> 
> the patch failed to apply cleanly:
> 
> patching file dom/telephony/test/marionette/manifest.ini
> Hunk #1 FAILED at 13
> Hunk #2 FAILED at 44
> 2 out of 2 hunks FAILED -- saving rejects to file
> dom/telephony/test/marionette/manifest.ini.rej
> patch failed, unable to continue (try -v)
> patch failed, rejects left in working dir
> errors during apply, please fix and refresh
> 0001-Disable-test-cases-due-to-emulator-changes.-r-hsinyi.patch
> 
> could you take a look, thanks!

I guess you were trying to land this one on b2g-inbound...
* Phase 1 - [final] Part 1: Disable test cases due to emulator changes. r=hsinyi

It's already done.
https://hg.mozilla.org/integration/b2g-inbound/rev/0df3fe71a38d

So, after it get into central.

Please help to merge the emulator PR
* Phase 2 - [platform_external_qemu] PR 119

Note that, this one cannot be landed at this time. It should wait until the emulator PR is working on try server
* Phase 3 - [final] Part 2: Fix tests: using waiting state. r=hsinyi
Flags: needinfo?(szchen) → needinfo?(cbook)
Keywords: checkin-needed
Now, it's the phase 2: we are going to update the emulator

try with emulator update looks good
https://tbpl.mozilla.org/?tree=Try&rev=f15deddcb60b

Please help to merge the pull request.
Phase 2 - [platform_external_qemu] PR 119
Flags: needinfo?(cbook)
Keywords: checkin-needed
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/3085bae6e32b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
check-in needed for kk branch
=> (kk) [platform_external_qemu] PR 123
Keywords: checkin-needed
No longer blocks: emulator-l_taskcluster
You need to log in before you can comment on or make changes to this bug.