1098193 - [Telephony] The state of incoming call should be WAITING if there are existing calls

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

Originally, the call state is always set to INCOMING. This is not correct. We should consider whether there are existing calls or not, and then set the state to WAITING or INCOMING accordingly.

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Phase 2 - [platform_external_qemu] PR 119

Edgar,

May I have your review? Thank you.

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8522086 [details] [review]
Phase 2 - [platform_external_qemu] PR 119

Leave some comments on github. Thank you.

Comment 3

[Edgar Chen [:edgar]]

Comment on attachment 8522086 [details] [review]
Phase 2 - [platform_external_qemu] PR 119

r=me, please help to provide a try result includes this qemu changes by updating `b2g/config/emualtor/sources.xml` (like https://hg.mozilla.org/try/rev/8d99fb03ee71) before requesting checkin-needed. Thank you.

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Fix tests: using waiting state

We have 'waiting' state now. Need to modeify some test cases.

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Phase 1 - Part 1: Disable test cases due to emulator changes

We have to disable affected tests for the emulator changes.

Comment 6

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Phase 3 - Part 2: Fix tests: using waiting state

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8522747 [details] [diff] [review]
Phase 1 - Part 1: Disable test cases due to emulator changes

Review of attachment 8522747 [details] [diff] [review]:
-----------------------------------------------------------------

Not really get the idea - why are all deleted items going to be added back in Phase3 patch?

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8522749 [details] [diff] [review]
Phase 3 - Part 2: Fix tests: using waiting state

Review of attachment 8522749 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good except the confusing part of manifest.ini @@?

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #7)
> Comment on attachment 8522747 [details] [diff] [review]
> Phase 1 - Part 1: Disable test cases due to emulator changes
> 
> Review of attachment 8522747 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Not really get the idea - why are all deleted items going to be added back
> in Phase3 patch?

Never mind, I got it... This is for you to be able to land emulator part safely. :)

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8522747 [details] [diff] [review]
Phase 1 - Part 1: Disable test cases due to emulator changes

Review of attachment 8522747 [details] [diff] [review]:
-----------------------------------------------------------------

For the sake of landing Part2 safely!

Comment 11

[Szu-Yu Chen [:aknow] (inactive)]

In order to land the patch smoothly, we have to separate it into 3 phases.
- phase1: disable the affected test cases
- phase2: merge emulator PR
- phase3: when change of phase 2 is available on try, re-enbale the test cases and fix them

For phase1 + phase2 (manually update the emulater path)
Try looks good
https://tbpl.mozilla.org/?tree=Try&rev=206c802119f3

Phase 1
https://hg.mozilla.org/integration/b2g-inbound/rev/0df3fe71a38d

Set checkin-needed for only => Phase 2 - [platform_external_qemu] PR 119
Thank you.

Comment 12

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Phase 1 - [final] Part 1: Disable test cases due to emulator changes. r=hsinyi

Comment 13

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Phase 3 - [final] Part 2: Fix tests: using waiting state. r=hsinyi

Comment 14

[Carsten Book [:Tomcat]]

Hi,

the patch failed to apply cleanly:

patching file dom/telephony/test/marionette/manifest.ini
Hunk #1 FAILED at 13
Hunk #2 FAILED at 44
2 out of 2 hunks FAILED -- saving rejects to file dom/telephony/test/marionette/manifest.ini.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 0001-Disable-test-cases-due-to-emulator-changes.-r-hsinyi.patch

could you take a look, thanks!

Comment 15

[Szu-Yu Chen [:aknow] (inactive)]

(In reply to Carsten Book [:Tomcat] from comment #14)
> Hi,
> 
> the patch failed to apply cleanly:
> 
> patching file dom/telephony/test/marionette/manifest.ini
> Hunk #1 FAILED at 13
> Hunk #2 FAILED at 44
> 2 out of 2 hunks FAILED -- saving rejects to file
> dom/telephony/test/marionette/manifest.ini.rej
> patch failed, unable to continue (try -v)
> patch failed, rejects left in working dir
> errors during apply, please fix and refresh
> 0001-Disable-test-cases-due-to-emulator-changes.-r-hsinyi.patch
> 
> could you take a look, thanks!

I guess you were trying to land this one on b2g-inbound...
* Phase 1 - [final] Part 1: Disable test cases due to emulator changes. r=hsinyi

It's already done.
https://hg.mozilla.org/integration/b2g-inbound/rev/0df3fe71a38d

So, after it get into central.

Please help to merge the emulator PR
* Phase 2 - [platform_external_qemu] PR 119

Note that, this one cannot be landed at this time. It should wait until the emulator PR is working on try server
* Phase 3 - [final] Part 2: Fix tests: using waiting state. r=hsinyi

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0df3fe71a38d

Comment 17

[Szu-Yu Chen [:aknow] (inactive)]

Now, it's the phase 2: we are going to update the emulator

try with emulator update looks good
https://tbpl.mozilla.org/?tree=Try&rev=f15deddcb60b

Please help to merge the pull request.
Phase 2 - [platform_external_qemu] PR 119

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/platform_external_qemu/commit/d9726c506be07252e32fc664250a938e25ab006f

Comment 19

[Szu-Yu Chen [:aknow] (inactive)]

try
https://tbpl.mozilla.org/?tree=Try&rev=fcc1af891773

Comment 20

[Szu-Yu Chen [:aknow] (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/3085bae6e32b

Comment 21

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3085bae6e32b

Comment 22

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: (kk) [platform_external_qemu] PR 123

Comment 23

[Szu-Yu Chen [:aknow] (inactive)]

check-in needed for kk branch
=> (kk) [platform_external_qemu] PR 123

Comment 24

[Ryan VanderMeulen [:RyanVM]]

b2g-kitkat: https://github.com/mozilla-b2g/platform_external_qemu/commit/041f359c411c07e6dbee353394c91361934b7315