Closed
Bug 1098193
Opened 10 years ago
Closed 9 years ago
[Telephony] The state of incoming call should be WAITING if there are existing calls
Categories
(Firefox OS Graveyard :: Emulator, defect)
Firefox OS Graveyard
Emulator
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S9 (21Nov)
People
(Reporter: aknow, Assigned: aknow)
References
Details
Attachments
(4 files, 3 obsolete files)
Originally, the call state is always set to INCOMING. This is not correct. We should consider whether there are existing calls or not, and then set the state to WAITING or INCOMING accordingly.
Assignee | ||
Comment 1•10 years ago
|
||
Edgar, May I have your review? Thank you.
Attachment #8522086 -
Flags: review?(echen)
Comment 2•10 years ago
|
||
Comment on attachment 8522086 [details] [review] Phase 2 - [platform_external_qemu] PR 119 Leave some comments on github. Thank you.
Attachment #8522086 -
Flags: review?(echen)
Comment 3•10 years ago
|
||
Comment on attachment 8522086 [details] [review] Phase 2 - [platform_external_qemu] PR 119 r=me, please help to provide a try result includes this qemu changes by updating `b2g/config/emualtor/sources.xml` (like https://hg.mozilla.org/try/rev/8d99fb03ee71) before requesting checkin-needed. Thank you.
Attachment #8522086 -
Flags: review+
Assignee | ||
Comment 4•10 years ago
|
||
We have 'waiting' state now. Need to modeify some test cases.
Attachment #8522741 -
Flags: review?(htsai)
Assignee | ||
Updated•10 years ago
|
Attachment #8522086 -
Attachment description: PR 119 → Phase 2: PR 119
Assignee | ||
Comment 5•10 years ago
|
||
We have to disable affected tests for the emulator changes.
Attachment #8522747 -
Flags: review?(htsai)
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8522741 -
Attachment is obsolete: true
Attachment #8522741 -
Flags: review?(htsai)
Attachment #8522749 -
Flags: review?(htsai)
Assignee | ||
Updated•10 years ago
|
Attachment #8522747 -
Attachment description: Phase 1: Part 1: Disable test cases due to emulator changes → Phase 1 - Part 1: Disable test cases due to emulator changes
Assignee | ||
Updated•10 years ago
|
Attachment #8522086 -
Attachment description: Phase 2: PR 119 → Phase 2 - PR 119
Comment 7•10 years ago
|
||
Comment on attachment 8522747 [details] [diff] [review] Phase 1 - Part 1: Disable test cases due to emulator changes Review of attachment 8522747 [details] [diff] [review]: ----------------------------------------------------------------- Not really get the idea - why are all deleted items going to be added back in Phase3 patch?
Comment 8•10 years ago
|
||
Comment on attachment 8522749 [details] [diff] [review] Phase 3 - Part 2: Fix tests: using waiting state Review of attachment 8522749 [details] [diff] [review]: ----------------------------------------------------------------- Looks good except the confusing part of manifest.ini @@?
Comment 9•10 years ago
|
||
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #7) > Comment on attachment 8522747 [details] [diff] [review] > Phase 1 - Part 1: Disable test cases due to emulator changes > > Review of attachment 8522747 [details] [diff] [review]: > ----------------------------------------------------------------- > > Not really get the idea - why are all deleted items going to be added back > in Phase3 patch? Never mind, I got it... This is for you to be able to land emulator part safely. :)
Comment 10•10 years ago
|
||
Comment on attachment 8522747 [details] [diff] [review] Phase 1 - Part 1: Disable test cases due to emulator changes Review of attachment 8522747 [details] [diff] [review]: ----------------------------------------------------------------- For the sake of landing Part2 safely!
Attachment #8522747 -
Flags: review?(htsai) → review+
Updated•10 years ago
|
Attachment #8522749 -
Flags: review?(htsai) → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8522086 -
Attachment description: Phase 2 - PR 119 → Phase 2 - [platform_external_qemu] PR 119
Assignee | ||
Comment 11•10 years ago
|
||
In order to land the patch smoothly, we have to separate it into 3 phases. - phase1: disable the affected test cases - phase2: merge emulator PR - phase3: when change of phase 2 is available on try, re-enbale the test cases and fix them For phase1 + phase2 (manually update the emulater path) Try looks good https://tbpl.mozilla.org/?tree=Try&rev=206c802119f3 Phase 1 https://hg.mozilla.org/integration/b2g-inbound/rev/0df3fe71a38d Set checkin-needed for only => Phase 2 - [platform_external_qemu] PR 119 Thank you.
Keywords: checkin-needed,
leave-open
Assignee | ||
Comment 12•10 years ago
|
||
Attachment #8522747 -
Attachment is obsolete: true
Attachment #8526564 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Attachment #8526564 -
Attachment description: [final] Part 1: Disable test cases due to emulator changes. r=hsinyi → Phase 1 - [final] Part 1: Disable test cases due to emulator changes. r=hsinyi
Assignee | ||
Comment 13•10 years ago
|
||
Attachment #8522749 -
Attachment is obsolete: true
Attachment #8526565 -
Flags: review+
Comment 14•10 years ago
|
||
Hi, the patch failed to apply cleanly: patching file dom/telephony/test/marionette/manifest.ini Hunk #1 FAILED at 13 Hunk #2 FAILED at 44 2 out of 2 hunks FAILED -- saving rejects to file dom/telephony/test/marionette/manifest.ini.rej patch failed, unable to continue (try -v) patch failed, rejects left in working dir errors during apply, please fix and refresh 0001-Disable-test-cases-due-to-emulator-changes.-r-hsinyi.patch could you take a look, thanks!
Flags: needinfo?(szchen)
Keywords: checkin-needed
Assignee | ||
Comment 15•10 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #14) > Hi, > > the patch failed to apply cleanly: > > patching file dom/telephony/test/marionette/manifest.ini > Hunk #1 FAILED at 13 > Hunk #2 FAILED at 44 > 2 out of 2 hunks FAILED -- saving rejects to file > dom/telephony/test/marionette/manifest.ini.rej > patch failed, unable to continue (try -v) > patch failed, rejects left in working dir > errors during apply, please fix and refresh > 0001-Disable-test-cases-due-to-emulator-changes.-r-hsinyi.patch > > could you take a look, thanks! I guess you were trying to land this one on b2g-inbound... * Phase 1 - [final] Part 1: Disable test cases due to emulator changes. r=hsinyi It's already done. https://hg.mozilla.org/integration/b2g-inbound/rev/0df3fe71a38d So, after it get into central. Please help to merge the emulator PR * Phase 2 - [platform_external_qemu] PR 119 Note that, this one cannot be landed at this time. It should wait until the emulator PR is working on try server * Phase 3 - [final] Part 2: Fix tests: using waiting state. r=hsinyi
Flags: needinfo?(szchen) → needinfo?(cbook)
Keywords: checkin-needed
Comment 16•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0df3fe71a38d
Keywords: checkin-needed
Assignee | ||
Comment 17•9 years ago
|
||
Now, it's the phase 2: we are going to update the emulator try with emulator update looks good https://tbpl.mozilla.org/?tree=Try&rev=f15deddcb60b Please help to merge the pull request. Phase 2 - [platform_external_qemu] PR 119
Flags: needinfo?(cbook)
Keywords: checkin-needed
Comment 18•9 years ago
|
||
Master: https://github.com/mozilla-b2g/platform_external_qemu/commit/d9726c506be07252e32fc664250a938e25ab006f
Keywords: checkin-needed
Updated•9 years ago
|
Blocks: emulator-kk
Assignee | ||
Comment 19•9 years ago
|
||
try https://tbpl.mozilla.org/?tree=Try&rev=fcc1af891773
Assignee | ||
Comment 20•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/3085bae6e32b
Assignee | ||
Updated•9 years ago
|
Keywords: leave-open
Comment 21•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3085bae6e32b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 22•9 years ago
|
||
Attachment #8539898 -
Flags: review+
Assignee | ||
Comment 23•9 years ago
|
||
check-in needed for kk branch => (kk) [platform_external_qemu] PR 123
Keywords: checkin-needed
Comment 24•9 years ago
|
||
b2g-kitkat: https://github.com/mozilla-b2g/platform_external_qemu/commit/041f359c411c07e6dbee353394c91361934b7315
Keywords: checkin-needed
Target Milestone: --- → 2.1 S9 (21Nov)
Updated•9 years ago
|
Blocks: emulator-l_taskcluster
Updated•9 years ago
|
No longer blocks: emulator-l_taskcluster
You need to log in
before you can comment on or make changes to this bug.
Description
•