Closed
Bug 1098210
Opened 10 years ago
Closed 10 years ago
Use enums for mvnoType in MozIcc.webidl and nsIIccProvider.idl
Categories
(Firefox OS Graveyard :: RIL, defect)
Firefox OS Graveyard
RIL
Tracking
(feature-b2g:2.2+)
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(1 file)
9.56 KB,
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
Use the enums for mvno type for the following API in both the WebIDL and IPDL interface. - matchMvno
Assignee | ||
Updated•10 years ago
|
Blocks: 864489, b2g-ril-interface
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8535540 [details] [diff] [review] Patch, v1 Review of attachment 8535540 [details] [diff] [review]: ----------------------------------------------------------------- Hi Hsinyi, may I have your review? Thank you.
Attachment #8535540 -
Flags: review?(htsai)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → echen
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2.2 S3 (9jan)
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 3•10 years ago
|
||
Comment on attachment 8535540 [details] [diff] [review] Patch, v1 Review of attachment 8535540 [details] [diff] [review]: ----------------------------------------------------------------- Awesome!
Attachment #8535540 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Try results: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=91263571e479
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/2bd2fad9eac0
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2bd2fad9eac0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 8•10 years ago
|
||
I backed out to check if that's causing the smoke test blocker bug 1114955 that has trouble getting reviewed.
https://hg.mozilla.org/mozilla-central/rev/74dc2a4ee7ef
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Ugh, mc-merge reopened for me...
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•10 years ago
|
||
changing stratus to REOPENED given that the patch is backed out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 12•10 years ago
|
||
Bug 1114955 is fixed. Re-land the patch. https://hg.mozilla.org/integration/b2g-inbound/rev/ce6b395d9b2e
Comment 13•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ce6b395d9b2e
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•