1098210 - Use enums for mvnoType in MozIcc.webidl and nsIIccProvider.idl

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

Use the enums for mvno type for the following API in both the WebIDL and IPDL interface.

- matchMvno

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8535540 [details] [diff] [review]
Patch, v1

Review of attachment 8535540 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Hsinyi, may I have your review? Thank you.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8535540 [details] [diff] [review]
Patch, v1

Review of attachment 8535540 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome!

Comment 4

[Edgar Chen [:edgar]]

Try results: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=91263571e479

Comment 5

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/2bd2fad9eac0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2bd2fad9eac0

Comment 7

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/74dc2a4ee7ef

Comment 8

[[:fabrice] Fabrice Desré]

I backed out to check if that's causing the smoke test blocker bug 1114955 that has trouble getting reviewed.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/74dc2a4ee7ef

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Ugh, mc-merge reopened for me...

Comment 11

[Edgar Chen [:edgar]]

changing stratus to REOPENED given that the patch is backed out.

Comment 12

[Edgar Chen [:edgar]]

Bug 1114955 is fixed. Re-land the patch.

https://hg.mozilla.org/integration/b2g-inbound/rev/ce6b395d9b2e

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ce6b395d9b2e