1098433 - Tabs tray on non-7" tablet looks crowded

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: Screenshot_2014-11-13-09-01-14.png

Is it me or do 5 items seem very crowded? I think we could either keep it consistent with the 7" (4 items) or tweak the padding a bit here.

Not sure that we need to block V1 on this, but here's the bug.

Comment 1

[Lucas Rocha (:lucasr)]

I assume we actually want 4 cells per row there?

Comment 2

[Aaron Train [:aaronmt]]

Personally, I'd rather have fewer items per row with much larger screenshots suitable for a landscape tablet

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I think 4 is our magic number here as a quick fix. 

BUT...

That being said, I want to try and play with the padding on both sides here because it also seems awfully large here compared to the 7. We may find that after we do that, 5 might be OK.

Thoughts?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #2)
> Personally, I'd rather have fewer items per row with much larger screenshots
> suitable for a landscape tablet

Just be careful with larger thumbnails. It takes more time and takes more memory.

Comment 5

[Aaron Train [:aaronmt]]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> (In reply to Aaron Train [:aaronmt] from comment #2)
> > Personally, I'd rather have fewer items per row with much larger screenshots
> > suitable for a landscape tablet
> 
> Just be careful with larger thumbnails. It takes more time and takes more
> memory.

I like to have nice things.

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

From the builds, I think 5 is still too congested and confusing. Looks extremely overwhelming when there are multiple rows. 

Let's go with 4 per row (horizontally).

Comment 7

[Lucas Rocha (:lucasr)]

Attachment: Improve tabs panel grid padding on large tablets (r=mcomella)

Comment 8

[Lucas Rocha (:lucasr)]

Comment on attachment 8526165 [details] [diff] [review]
Improve tabs panel grid padding on large tablets (r=mcomella)

As per discussion with antlam.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8526165 [details] [diff] [review]
Improve tabs panel grid padding on large tablets (r=mcomella)

Review of attachment 8526165 [details] [diff] [review]:
-----------------------------------------------------------------

If the antlam says okay, mcomella says okay.

Comment 10

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/46b9f69a642f

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/46b9f69a642f