1098585 - Get rid of __iterator__ in calendar/

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

bug 694100 wants to remove __iterator__, we should remove it from calendar. I guess ES6 iterators are the new thing.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Sorry, wrong bug. I meant bug 1098412.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This needs to be done for bug 1280898. We need to get rid of all old-style generators (non-star-function with yield keyword in use) so that eslint will not barf.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b56bef0b73dc

Comment 4

[[:MakeMyDay]]

Comment on attachment 8763714 [details] [diff] [review]
Fix - v1

Review of attachment 8763714 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just one minor nit. r=me

::: calendar/base/modules/calIteratorUtils.jsm
@@ +72,4 @@
>                      }
>                  }
> +
> +                if (done) {

Simply use else here.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to [:MakeMyDay] from comment #4)
> > +                if (done) {
> 
> Simply use else here.

else would not work, because there is a case where |done| is changed in the first if block a few lines up. This second if should also catch that case.

Comment 6

[Jorg K (GMT+1) (PTO to 15th Dec 2019, sporadically reading bugmail)]

https://hg.mozilla.org/comm-central/rev/c8afe5b01783