Closed
Bug 1098585
Opened 6 years ago
Closed 5 years ago
Get rid of __iterator__ in calendar/
Categories
(Calendar :: Internal Components, defect)
Calendar
Internal Components
Tracking
(Not tracked)
RESOLVED
FIXED
5.2
People
(Reporter: Fallen, Assigned: Fallen)
References
()
Details
Attachments
(1 file)
38.10 KB,
patch
|
MakeMyDay
:
review+
|
Details | Diff | Splinter Review |
bug 694100 wants to remove __iterator__, we should remove it from calendar. I guess ES6 iterators are the new thing.
Assignee | ||
Comment 1•6 years ago
|
||
Sorry, wrong bug. I meant bug 1098412.
Updated•6 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
This needs to be done for bug 1280898. We need to get rid of all old-style generators (non-star-function with yield keyword in use) so that eslint will not barf.
Assignee | ||
Comment 3•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b56bef0b73dc
Attachment #8763714 -
Flags: review?(makemyday)
Comment 4•5 years ago
|
||
Comment on attachment 8763714 [details] [diff] [review] Fix - v1 Review of attachment 8763714 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, just one minor nit. r=me ::: calendar/base/modules/calIteratorUtils.jsm @@ +72,4 @@ > } > } > + > + if (done) { Simply use else here.
Attachment #8763714 -
Flags: review?(makemyday) → review+
Assignee | ||
Comment 5•5 years ago
|
||
(In reply to [:MakeMyDay] from comment #4) > > + if (done) { > > Simply use else here. else would not work, because there is a case where |done| is changed in the first if block a few lines up. This second if should also catch that case.
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Comment 6•5 years ago
|
||
https://hg.mozilla.org/comm-central/rev/c8afe5b01783
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 5.2
Updated•5 years ago
|
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•