1098997 - [Window Management] The user cannot return home in card view, solving by remove legacy code in lockscree.js

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

+++ This bug was initially created as a clone of Bug #1088157 +++

Tim suggests me to make a complete solution by replacing the legacy code with new, window visibility depends on solution.

Comment 2

[bhavana bajaj [:bajaj]]

Blocking for 2.2 as we have already fixed this in 2.1 in https://bugzilla.mozilla.org/show_bug.cgi?id=1088157 and want to ensure this will fixed as a follow-up on trunk.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Bug 1101418 would provide what we want.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Greg, are you expecting to fix Bug 1101418 for 2.2, or should I try land a similar fix to bug 1088157?

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

From the latest discussion we decide to expect the complete solution is too risky, so yes, please do it. However, to handle FTU in LockScreen is still a bit risky, so there could be some unexpected regressions that I think we should take some manual test after the landing.

Comment 6

[Sam Foster [:sfoster] (he/him)]

I've not actually seen this bug reproduce on master. Can we check this (master/nightly only) 
The original STR: 

Repro Steps :
1)  Flash phone (e.g reset-gaia) to ensure FTU runs
    (must be true first-run, not launching FTU from Developer menu)
(do NOT wait long enough for the lockscreen to show up at any point in the following steps)
1.5 step through the FTU
2)  Open up any app.
3)  Press and hold the home button on the device to enter card view.
4)  While in card view, tap the home button on the device to go to the homescreen.

Actual:
The user is not taken to the homescreen when tapping the home button in card view.

Expected:
The user is returned to the homescreen when they tap the home button on the dut.

Comment 7

[Cody Roesch [:croesch]]

In the latest Flame 2.2 KK nightly build below, after a fresh flash, when I open an app such as SMS app or Settings, I then put the app into card view and when I hit the home button, the app comes back into full screen instead of going to the homescreen.

Reproduce: 10/10

Environmental Variables:
Device: Flame 2.2 Nightly
BuildID: 20141218040201
Gaia: 58734e8a48157f99d5b733412b600c2e04c954fe
Gecko: 5c7a6294b82a
Version: 37.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 8

[Sam Foster [:sfoster] (he/him)]

(In reply to Cody Roesch [:croesch] from comment #7)
> In the latest Flame 2.2 KK nightly build below, after a fresh flash, when I
> open an app such as SMS app or Settings, I then put the app into card view
> and when I hit the home button, the app comes back into full screen instead
> of going to the homescreen.

That is not the same issue as the original 2.1 bug that this bug clones - there the issue was that on the first use of the task manager, the home button was completely non-functional and you got stuck in task-manager. I'm not clear if the current behavior (home returns to active app) is what we want for 2.2. Francis, I guess we need to talk about best case and minimal case for task manager in 2.2. I'm inclined to close this bug as worksforme but I'll let you chime in first?

Comment 9

[Cody Roesch [:croesch]]

Sam,
   Ok I understand. In that case the bug does NOT reproduce in the build I tested above.

Comment 10

[howie [:howie]]

resolved worksforme based on Comment 9