1099009 - Implement webmaker-login-ux on non-angular webmakerorg pages

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[Adam Lofting (:adamlofting)]

Attachment: Screen Shot 2014-11-14 at 09.47.00.png

Immediately after the steps recorded in Bug 1099007 I clicked on the profile drop-down and "My Makes" to get the following error. (screenshot attached)

Error: template not found: webmaker-auth-client/create-user/create-user-form.html at null.<anonymous> (/var/www/webmakerorg/node_modules/nunjucks/src/environment.js:149:31) at next (/var/www/webmakerorg/node_modules/nunjucks/src/lib.js:201:13) at handle (/var/www/webmakerorg/node_modules/nunjucks/src/environment.js:134:25) at /var/www/webmakerorg/node_modules/nunjucks/src/environment.js:145:21 at next (/var/www/webmakerorg/node_modules/nunjucks/src/lib.js:198:13) at Object.exports.asyncIter (/var/www/webmakerorg/node_modules/nunjucks/src/lib.js:205:5) at Obj.extend.getTemplate (/var/www/webmakerorg/node_modules/nunjucks/src/environment.js:128:17) at eval (eval at <anonymous> (/var/www/webmakerorg/node_modules/nunjucks/src/environment.js:388:24), <anonymous>:74:5) at b_css (eval at <anonymous> (/var/www/webmakerorg/node_modules/nunjucks/src/environment.js:388:24), <anonymous>:216:1) at eval (eval at <anonymous> (/var/www/webmakerorg/node_modules/nunjucks/src/environment.js:388:24), <anonymous>:57:24)

Comment 2

[Jon Buckley [:jbuck]]

Some webmaker.org pages haven't been converted to Angular yet, which is why they're blowing up when trying to reference the now removed webmaker-auth-client.

Comment 3

[Chris DeCairos (:cade)]

Should we add it back in? or implement the plainjs adapter?

Comment 4

[Jon Buckley [:jbuck]]

/gallery
/gallery/list/:list <-- I don't know if this does anything useful
/editor <-- For editing galleries I think? Doesn't seem to work though
/privacy-makes
/badges/*
/admin/badges
/search
/literacy/exploring <-- This doesn't work
/literacy/building <-- This doesn't work
/literacy/connecting <-- This doesn't work
/style-guide
/details
/me
/terms
/privacy
/languages

Based on this list, I think implementing the plainjs adapter makes the most sense.

Comment 5

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/webmaker.org/pull/1047

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/1b38624340145d12c8b0861265c8ca9385333dd3
Bug 1099009 - Implement login 3.0 for non-Angular pages

Comment 7

[Jon Buckley [:jbuck]]

Comment on attachment 8538748 [details] [review]
https://github.com/mozilla/webmaker.org/pull/1047

kate and wex r+'d this.