Closed Bug 1099332 Opened 11 years ago Closed 11 years ago

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/test_empty_search.js | xpcshell return code: 0

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox34 --- unaffected
firefox35 --- unaffected
firefox36 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: jcranmer, Assigned: hiro)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 2 obsolete files)

10:05:19 INFO - Didn't find the current result ('moz-action:searchengine,{"engineName":"Bing","input":"foo","searchQuery":"foo"}', 'Bing') in matches 10:05:19 INFO - /builds/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js:check_autocomplete:189 10:05:19 INFO - self-hosted:next:885 10:05:19 INFO - Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23 10:05:19 INFO - this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7 10:05:19 INFO - this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37 10:05:19 INFO - _do_main@/builds/slave/test/build/tests/xpcshell/head.js:184:5 10:05:19 INFO - _execute_test@/builds/slave/test/build/tests/xpcshell/head.js:372:5 10:05:19 INFO - @-e:1:1 10:05:19 INFO - exiting test 10:05:19 INFO - Unexpected exception 2147500036 10:05:19 INFO - undefined 10:05:19 INFO - exiting test
I have no idea other than moving searchplugins into a sub directory in dist/bin/ to fix these failures.
Blocks: 530209
Depends on: 1099852
I noticed each search engine has 'hidden' property. We can use the property to disable all engines. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=881237c21323
Assignee: nobody → hiikezoe
Attachment #8525006 - Flags: review?(mak77)
No longer depends on: 1099852
Comment on attachment 8525006 [details] [diff] [review] Ensure that thre is no active search engines before test run Review of attachment 8525006 [details] [diff] [review]: ----------------------------------------------------------------- would this pass a Try run if you'd do this in /toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js cause that way we'd catch all tests.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=79df7df3d872 There was one failure on toolkit/components/jsdownloads/test/unit/test_DownloadIntegration.js , but in theory it is not related this change.
Attachment #8525006 - Attachment is obsolete: true
Attachment #8525006 - Flags: review?(mak77)
Attachment #8527132 - Flags: review?(mak77)
Comment on attachment 8527132 [details] [diff] [review] Ensure that thre is no active search engines before each test run Review of attachment 8527132 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js @@ +296,5 @@ > let url = "moz-action:" + action + "," + JSON.stringify(params); > return NetUtil.newURI(url); > } > + > +add_task(function ensure_no_search_engines() { Could you please add a comment above this explaining what this is doing and why? So anyone looking at this can know. Something like // Hide all the search engines so they don't influence tests results.
Attachment #8527132 - Flags: review?(mak77) → review+
carrying over review+. Thanks for reviewing!
Attachment #8527132 - Attachment is obsolete: true
Attachment #8528288 - Flags: review+
Component: General → Places
Keywords: checkin-needed
Product: Thunderbird → Toolkit
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: