Use shorter brandShortName for Firefox Developer Edition

RESOLVED FIXED in Firefox 38

Status

()

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: heycam, Assigned: Gijs)

Tracking

unspecified
Firefox 38
Points:
2
Bug Flags:
firefox-backlog +
in-testsuite -
qe-verify -

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Posted image screen shot
The Help submenu of the application menu in Firefox Developer Edition has a few items that are cut off with an ellipsis, presumably because the string "Firefox Developer Edition" is a lot longer than "Firefox" is.
(Assignee)

Comment 1

5 years ago
I wonder if we should use a shorter version of the brand name in cases such as these (which would probably just be "Firefox") or if that's going to lead to other issues. Gavin/Joe, opinions? :-)
Flags: needinfo?(jwalker)
Flags: needinfo?(gavin.sharp)
(Assignee)

Updated

5 years ago
Component: General → Toolbars and Customization
Situation by OS:
- Mac OS X 10.9.5 - I see the same issues as reported
- Ubuntu 14.04 x64 - all strings fit except for "Firefox Developer Edition Health Report"
- Windows 7 x64 - NO issues (all the strings fit)
(In reply to :Gijs Kruitbosch from comment #1)
> I wonder if we should use a shorter version of the brand name in cases such
> as these (which would probably just be "Firefox") or if that's going to lead
> to other issues. Gavin/Joe, opinions? :-)

Yes, it's called brandShortName (vs. brandFullname) for a reason. ;) FirefoxDev is the shortest I can come up with if we don't want to use just Firefox.
(Assignee)

Comment 4

5 years ago
(In reply to Dão Gottwald [:dao] from comment #3)
> (In reply to :Gijs Kruitbosch from comment #1)
> > I wonder if we should use a shorter version of the brand name in cases such
> > as these (which would probably just be "Firefox") or if that's going to lead
> > to other issues. Gavin/Joe, opinions? :-)
> 
> Yes, it's called brandShortName (vs. brandFullname) for a reason. ;)

Quite. :-)

I assumed there was already a distinction, and/or we use brandShortName in places where we really do want the longer edition. Either those should be using brandFullName (I'm hoping the capitalization is consistent...) or we need a brandShorterName. (is it MFBT yet? :-( )
(In reply to :Gijs Kruitbosch from comment #1)
> I wonder if we should use a shorter version of the brand name in cases such
> as these (which would probably just be "Firefox") or if that's going to lead
> to other issues. Gavin/Joe, opinions? :-)

I think there are several places where "Firefox" makes the most sense, but I'm not against "FirefoxDev".
Flags: needinfo?(jwalker)
I think dev edition should use a shorter brandShortName, yes. I think "Firefox Dev" would be fine.
Flags: needinfo?(gavin.sharp)
(Assignee)

Comment 7

5 years ago
Marco, can you add this?
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 37.1
Points: --- → 2
Component: Toolbars and Customization → General
Flags: qe-verify-
Flags: needinfo?(mmucci)
Flags: in-testsuite-
Flags: firefox-backlog+
Summary: application menu Help submenu items are cut off in Firefox Developer Edition → Use shorter brandShortName for Firefox Developer Edition
(Assignee)

Comment 8

5 years ago
Posted patch rename devedition branding, (obsolete) — Splinter Review
Attachment #8529784 - Flags: review?(jwalker)
Attachment #8529784 - Flags: review?(gavin.sharp)
Added to IT 37.1
Flags: needinfo?(mmucci)
AFAIK the reason we didn't go with this originally is because UX and/or Marketing didn't like it. So we need sign-off from UX at least.
Attachment #8529784 - Flags: review?(gavin.sharp) → feedback?(shorlander)
Iteration: 37.1 → 37.2
Personally, I'd prefer "Firefox DevEdition". It should still fit.
(Assignee)

Comment 12

4 years ago
(In reply to Joe Walker [:jwalker] (overloaded - needinfo me or ping on irc) from comment #11)
> Personally, I'd prefer "Firefox DevEdition". It should still fit.

"Firefox DevEdition Health Report" doesn't fit, unfortunately.
(In reply to :Gijs Kruitbosch from comment #12)
> (In reply to Joe Walker [:jwalker] (overloaded - needinfo me or ping on irc)
> from comment #11)
> > Personally, I'd prefer "Firefox DevEdition". It should still fit.
> 
> "Firefox DevEdition Health Report" doesn't fit, unfortunately.

How hard would it be to just have "Firefox" for this menu?
(Assignee)

Comment 14

4 years ago
(In reply to Joe Walker [:jwalker] (overloaded - needinfo me or ping on irc) from comment #13)
> (In reply to :Gijs Kruitbosch from comment #12)
> > (In reply to Joe Walker [:jwalker] (overloaded - needinfo me or ping on irc)
> > from comment #11)
> > > Personally, I'd prefer "Firefox DevEdition". It should still fit.
> > 
> > "Firefox DevEdition Health Report" doesn't fit, unfortunately.
> 
> How hard would it be to just have "Firefox" for this menu?

I mean, hardcoding it is easy, but that'd also make it say "Firefox" instead of "Nightly", which we definitely don't want. Fixing it to just hardcode Firefox when using the aurora branding would require an extra (duplicate) string and some code. Can't say I'm jumping up and down with excitement for that solution, but it's a possibility.
Iteration: 37.2 → 37.3
(Assignee)

Updated

4 years ago
See Also: → 1110862
See Also: → 1101475
Iteration: 37.3 - 12 Jan → 38.1 - 26 Jan
(In reply to :Gijs Kruitbosch from comment #14)
> (In reply to Joe Walker [:jwalker] (overloaded - needinfo me or ping on irc)
> from comment #13)
> > (In reply to :Gijs Kruitbosch from comment #12)
> > > (In reply to Joe Walker [:jwalker] (overloaded - needinfo me or ping on irc)
> > > from comment #11)
> > > > Personally, I'd prefer "Firefox DevEdition". It should still fit.
> > > 
> > > "Firefox DevEdition Health Report" doesn't fit, unfortunately.
> > 
> > How hard would it be to just have "Firefox" for this menu?
> 
> I mean, hardcoding it is easy, but that'd also make it say "Firefox" instead
> of "Nightly", which we definitely don't want. Fixing it to just hardcode
> Firefox when using the aurora branding would require an extra (duplicate)
> string and some code. Can't say I'm jumping up and down with excitement for
> that solution, but it's a possibility.

This has been on my plate too long because I don't have a good answer. I don't like "Firefox DevEdition", but it might be the least bad solution. Really it's a UX call.

My only other thought is to do "Firefox DevEdition".split(" ")[0], but I'm fairly sure that's going to have problems if not now, then in the future.
Comment on attachment 8529784 [details] [diff] [review]
rename devedition branding,

Review of attachment 8529784 [details] [diff] [review]:
-----------------------------------------------------------------

I'm happy with whatever you UX think we should do here.
Attachment #8529784 - Flags: review?(jwalker) → review+
Iteration: 38.1 - 26 Jan → 38.2 - 9 Feb
(Assignee)

Comment 17

4 years ago
Madhava, Philipp, Stephen, can someone make a decision about this name? Please see the other comments on this bug for context.
Flags: needinfo?(shorlander)
Flags: needinfo?(philipp)
Flags: needinfo?(madhava)
Assuming this doesn't create problems in other places, let's just use »Firefox« in places with limited space.
Flags: needinfo?(shorlander)
Flags: needinfo?(philipp)
Flags: needinfo?(madhava)
(Assignee)

Comment 19

4 years ago
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6f943468587
Flags: needinfo?(gijskruitbosch+bugs)
(Assignee)

Comment 20

4 years ago
Doing a casual audit with the builds from the trypush in comment #19, going with "Firefox" generally seems fine, except for the preference window ("Running Firefox and Firefox at the same time...") and the about dialog ("Firefox is experimental and may be unstable. It automatically sends ... to help make Firefox better"). I'm going to put up another patch that replaces some of these with the longer version of the brand name instead, then ask for review again.
Flags: needinfo?(gijskruitbosch+bugs)
(Assignee)

Comment 21

4 years ago
(In reply to :Gijs Kruitbosch from comment #20)
> Doing a casual audit with the builds from the trypush in comment #19, going
> with "Firefox" generally seems fine, except for the preference window
> ("Running Firefox and Firefox at the same time...") and the about dialog
> ("Firefox is experimental and may be unstable. It automatically sends ... to
> help make Firefox better"). I'm going to put up another patch that replaces
> some of these with the longer version of the brand name instead, then ask
> for review again.

Actually, thinking about it, that won't work well... and comment #18 says the inverse, so let's try something else...
(Assignee)

Comment 22

4 years ago
So, this adds a separate brand string and then uses that in the menu. It seemed the simplest way to do different strings specifically for devedition, only where there was a lack of space.
Attachment #8560639 - Flags: review?(jwalker)
(Assignee)

Updated

4 years ago
Attachment #8560639 - Flags: review?(MattN+bmo)
Comment on attachment 8560639 [details] [diff] [review]
make some uses of brandname shorter still,

foo.label should generally become foo2.label, not foo.label2
(Assignee)

Comment 24

4 years ago
OK, but then the other keys get updated too...
Attachment #8560685 - Flags: review?(jwalker)
(Assignee)

Updated

4 years ago
Attachment #8560639 - Attachment is obsolete: true
Attachment #8560639 - Flags: review?(jwalker)
Attachment #8560639 - Flags: review?(MattN+bmo)
(Assignee)

Updated

4 years ago
Attachment #8560685 - Flags: review?(MattN+bmo)
(Assignee)

Updated

4 years ago
Attachment #8529784 - Flags: feedback?(shorlander)
(Assignee)

Updated

4 years ago
Attachment #8529784 - Attachment is obsolete: true
Attachment #8560685 - Flags: review?(jwalker) → review+
Iteration: 38.2 - 9 Feb → 38.3 - 23 Feb
Comment on attachment 8560685 [details] [diff] [review]
make some uses of brandname shorter still,

Review of attachment 8560685 [details] [diff] [review]:
-----------------------------------------------------------------

BTW. this type of review is much easier on mozreview since it shows what changed within a line.

I very much prefer the approach of comment 19 /comment 20 which aligns with Gavin and Dão's suggestions as this feels like we're just adding technical debt to the codebase just for DevEdition.

(In reply to :Gijs Kruitbosch from comment #4)
> :-(

^ This is how I feel too and it's why I've been putting this off as I was hoping to come up with another solution.

r=me if gavin is fine with the technical debt we're adding.
Attachment #8560685 - Flags: review?(gavin.sharp)
Attachment #8560685 - Flags: review?(MattN+bmo)
Attachment #8560685 - Flags: review+
(Assignee)

Comment 26

4 years ago
FWIW, the difficulty here with brandFullName is that that's "Mozilla Firefox" on release, and so it's not really a great substitute for things where we currently use "Firefox". OTOH, I guess for the "X is unstable" and for the multi-profile pref string, that might not matter very much...

The other alternative is adding a different string and using that only where we want the long version on devedition, and making it === brandShortName for the other channels.
Attachment #8560685 - Flags: review?(gavin.sharp) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fba1266ee2e7
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
(In reply to :Gijs Kruitbosch from comment #26)
> FWIW, the difficulty here with brandFullName is that that's "Mozilla
> Firefox" on release

FWIW, note that brandFullName is "Firefox Developer Edition" for aurora and "Nightly" for nightly, so we're happy for Mozilla not appearing for those builds... maybe we actually don't need "Mozilla" in brandFullName in releases.
You need to log in before you can comment on or make changes to this bug.